Author Topic: Updated Uniaud32 build  (Read 370959 times)

Mark Szkolnicki

  • Sr. Member
  • ****
  • Posts: 433
  • Karma: +18/-0
    • View Profile
Re: Updated Uniaud32 build
« Reply #765 on: September 06, 2022, 02:33:10 am »
Thanks Andy, I'll revert the kzalloc change this evening my time and provide a new build.

Same here Paul - no sound still, on Hyperfire, but at least no trap using the 04 build.

M
Vincit Que Se Vincit - "He Who Conquers Self Succeeds"

Paul Smedley

  • Hero Member
  • *****
  • Posts: 2092
  • Karma: +159/-0
    • View Profile
Re: Updated Uniaud32 build
« Reply #766 on: September 06, 2022, 11:17:26 am »
For those who had traps with 0904b or 0905 - please try with https://smedley.id.au/tmp/uniaud32-linux-5.15.65-20220906.zip - this build reverts the changes in https://trac.netlabs.org/uniaud/changeset/723

Mark Szkolnicki

  • Sr. Member
  • ****
  • Posts: 433
  • Karma: +18/-0
    • View Profile
Re: Updated Uniaud32 build
« Reply #767 on: September 06, 2022, 04:46:29 pm »
Hi Paul!

For those who had traps with 0904b or 0905 - please try with https://smedley.id.au/tmp/uniaud32-linux-5.15.65-20220906.zip - this build reverts the changes in https://trac.netlabs.org/uniaud/changeset/723

The 5.15.65 20220906 build seems to have cleared the trap 000e on Hyperfire with the HDA ALC892 chipset. Still no sound, but exactly the same state as the 5.15.59 20220904 build (no sound but 10 volume sections reported in PMUnimix).

Just tested Manticore II on the 20220906 build as well, with the HDA AD1988B chipset. everything humming along there as well with the new build, as per all the recent previous builds - system sounds working and PM123 plays sound perfectly.

Best!

M
« Last Edit: September 06, 2022, 06:44:39 pm by Mark Szkolnicki »
Vincit Que Se Vincit - "He Who Conquers Self Succeeds"

Andy Willis

  • Sr. Member
  • ****
  • Posts: 292
  • Karma: +7/-0
    • View Profile
Re: Updated Uniaud32 build
« Reply #768 on: September 07, 2022, 02:58:08 am »

Paul Smedley

  • Hero Member
  • *****
  • Posts: 2092
  • Karma: +159/-0
    • View Profile
Re: Updated Uniaud32 build
« Reply #769 on: September 07, 2022, 04:49:38 am »
Hey Guys,

For those who had traps with 0904b or 0905 - please try with https://smedley.id.au/tmp/uniaud32-linux-5.15.65-20220906.zip - this build reverts the changes in https://trac.netlabs.org/uniaud/changeset/723
Works here.

Thanks for confirming - next to figure out why the revised kzalloc implementation wasn't working!

Lars

  • Hero Member
  • *****
  • Posts: 1271
  • Karma: +65/-0
    • View Profile
Re: Updated Uniaud32 build
« Reply #770 on: September 07, 2022, 09:16:51 am »
I can tell you why:
if you allocate more than a page, kmalloc uses vmalloc and returns right away, without applying the zeroing flag.

Paul Smedley

  • Hero Member
  • *****
  • Posts: 2092
  • Karma: +159/-0
    • View Profile
Re: Updated Uniaud32 build
« Reply #771 on: September 07, 2022, 11:12:44 am »
Hey Lars!

I can tell you why:
if you allocate more than a page, kmalloc uses vmalloc and returns right away, without applying the zeroing flag.

Thanks!! I haven't commited the change yet, but https://smedley.id.au/tmp/uniaud32-linux-5.15.65-20220907.zip will hopefully still work for those that previously had traps :)

Cheers,

Paul

Lars

  • Hero Member
  • *****
  • Posts: 1271
  • Karma: +65/-0
    • View Profile
Re: Updated Uniaud32 build
« Reply #772 on: September 07, 2022, 11:18:08 am »
I also wonder where these umpteen allocation routines come from. They all seem to do about the same thing.
Another thing: "copy_from_user" and "copy_to_user" could make good use of the KEE routines "KernCopyIn" and "KernCopyOut" respectively. These will catch traps if the user  buffer address or the access to it is invalid and will fail gracefully without bringing down the whole system.

Mike Kölling

  • Full Member
  • ***
  • Posts: 130
  • Karma: +6/-0
    • View Profile
Re: Updated Uniaud32 build
« Reply #773 on: September 07, 2022, 11:22:26 am »
Thanks!! I haven't commited the change yet, but https://smedley.id.au/tmp/uniaud32-linux-5.15.65-20220907.zip will hopefully still work for those that previously had traps :)

TRAP is gone on my TP X250 after installing the latest version "uniaud32-linux-5.15.65-20220907.zip".
Thank you Paul.

Greetings, Mike

Mark Szkolnicki

  • Sr. Member
  • ****
  • Posts: 433
  • Karma: +18/-0
    • View Profile
Re: Updated Uniaud32 build
« Reply #774 on: September 07, 2022, 04:12:58 pm »
Hey Lars!

I can tell you why:
if you allocate more than a page, kmalloc uses vmalloc and returns right away, without applying the zeroing flag.

Thanks!! I haven't commited the change yet, but https://smedley.id.au/tmp/uniaud32-linux-5.15.65-20220907.zip will hopefully still work for those that previously had traps :)

Cheers,

Paul

Hi Paul!

Running out the door today but just tried 0907:

Manticore II - The new build works fine with the AD1988B chipset, as always

Hyperfire - No Traps with the ALC892 chipset, but still no sound, so same status

Best!

M
Vincit Que Se Vincit - "He Who Conquers Self Succeeds"

Eugene Tucker

  • Sr. Member
  • ****
  • Posts: 368
  • Karma: +12/-0
    • View Profile
Re: Updated Uniaud32 build
« Reply #775 on: September 07, 2022, 04:24:30 pm »
Paul latest drop working well here ad in fact soundig quit good. Cleaner sound it seems.

David McKenna

  • Hero Member
  • *****
  • Posts: 743
  • Karma: +24/-0
    • View Profile
Re: Updated Uniaud32 build
« Reply #776 on: September 07, 2022, 11:59:05 pm »
Hi Paul,

  Build 20220907 is working fine here... thanks!

Regards,

Paul Smedley

  • Hero Member
  • *****
  • Posts: 2092
  • Karma: +159/-0
    • View Profile
Re: Updated Uniaud32 build
« Reply #777 on: September 08, 2022, 11:23:14 am »
https://smedley.id.au/tmp/uniaud32-linux-5.15.65-20220908.zip is now available - adds support for the __GFP_ZERO flag in __vmalloc, which fixes audio on some emu10k1 audio cards.

This may also fix some other stuff too - certainly shouldn't break anything :)

Mike Kölling

  • Full Member
  • ***
  • Posts: 130
  • Karma: +6/-0
    • View Profile
Re: Updated Uniaud32 build
« Reply #778 on: September 08, 2022, 12:14:29 pm »
https://smedley.id.au/tmp/uniaud32-linux-5.15.65-20220908.zip is now available - adds support for the __GFP_ZERO flag in __vmalloc, which fixes audio on some emu10k1 audio cards.

This may also fix some other stuff too - certainly shouldn't break anything :)

Hi Paul,

works on my TP X250. tested with system sound and pm123  :) - Thanks.

Greetings, Mike

Paul Smedley

  • Hero Member
  • *****
  • Posts: 2092
  • Karma: +159/-0
    • View Profile
Re: Updated Uniaud32 build
« Reply #779 on: September 08, 2022, 12:16:35 pm »
Thanks for testing Mike, now that most of the uniaud32 issues appear to be resolved, I'll get back to stabilising smbd - in particular when sharing resources that are Netdrive mounts.