Author Topic: DISKIO - updated version in need of TEST  (Read 49524 times)

Lars

  • Hero Member
  • *****
  • Posts: 1421
  • Karma: +72/-0
    • View Profile
Re: DISKIO - updated version in need of TEST
« Reply #15 on: December 24, 2020, 01:32:14 pm »
You need to supply a compiler switch use use C++ comments in plain C code (.c files).

Andreas Schnellbacher

  • Hero Member
  • *****
  • Posts: 827
  • Karma: +14/-0
    • View Profile
Re: DISKIO - updated version in need of TEST
« Reply #16 on: December 24, 2020, 02:30:32 pm »
Ah yes, it's - Ss+ or /Ss+.

Dave Yeo

  • Hero Member
  • *****
  • Posts: 5339
  • Karma: +126/-1
    • View Profile
Re: DISKIO - updated version in need of TEST
« Reply #17 on: December 24, 2020, 06:44:04 pm »
I tried VACPP 3.08 with no joy, didn't even like the CPLUS type comments.
BTW: No, that can't be the reason. "//" is defined in VAC 3.0.8 as single-line comment string, as well as C-Set/2 supports this.

Well, it sure complained. Here, I just added a CPLUS type comment on line 9 and get,
Code: [Select]
icc -q -Wpro -O -qtune=pentium2 -Gl -Gm -Gs -DOS2TMR -DOS2 -c cpuperf.c
warning EDC1020: Excess text tune=pentium2 ignored on /q option.
cpuperf.c(9:1) : error EDC0046: Syntax error.
cpuperf.c(9:4) : error EDC0166: Definition of function a requires parentheses.
...
Then problems like not knowing what __uint64 is, after I fixed the comments to be C type, so I switched to OW.

Dariusz Piatkowski

  • Hero Member
  • *****
  • Posts: 1421
  • Karma: +28/-0
    • View Profile
Re: DISKIO - updated version in need of TEST
« Reply #18 on: December 27, 2020, 06:07:13 pm »
Hi Dave!

Well, ideally would be to keep the Win32 codebase and binaries so people can do comparisons. Of course if you have no motivation to do that, you could remove them, while leaving them in history in case someone wants to resurrect them, and do a major version jump to ver 2 or fork by renaming your binary.

Yeah, "ideally" is a great point to note. This was my initial thinking as well but given what I see as diminishing returns on preserving the Win32 stuff I will simply fork the non-Win32 login into a 2.00.00 release, which will be purse OS/2 only stuff.

...You're the one taking on the maintainer-ship.
Hopefully you're using something like Git to maintain history.

Well, my track record is spotty at best when it comes to 'wanting' and actually 'doing' - think FFMPEG from some years ago when you and I had a few conversation on this topic. My interest was in chasing down an audio artifact I was seeing in the current FFMPEG builds. Regardless, that issue was addressed by an updated build and so I never moved further along with my idea.

...BTW, which compiler are you using? I tried VACPP 3.08 with no joy, didn't even like the CPLUS type comments. It did build fine with OpenWatcom with this patch.

I've got VACPP 3.65 with FP2 installed here, so that is what's being used. I have transitioned to NMAKE32 as opposed to the old NMAKE, but that's only because VACPP moved that way so I figured I'd just settle on the latest release and run with it.

From a "problems encountered so far" side of things I can only think of two issues:

1) undefined variables in dhry_1.c: Int_1_Loc, Int_2_Loc, Int_3_Loc, etc.
Maybe I'm just misunderstanding how DISKIO is supposed to be built, but running the makefile causes everything to be compiled, and yet I kept on getting missing declarations for the variables in the DEBUG section of dhry_1.c, see the stuff in:

Code: [Select]
...
  printf ("Execution ends\n");
  printf ("\n");
#if 1
  printf ("Final values of the variables used in the benchmark:\n");
  printf ("\n");
  printf ("Int_Glob:            %d\n", Int_Glob);
...

Since some of these variables were defined in dhry_1.c and others were not, I simply added them to dhry_1.c. That caused my errors to go away, but the variables are not populated with any values during runtime, so something else is missing there.

2) INCLUDE directories and VACPP vs OS2_Toolkit vs GCC setups
On my machine I have all three installed.

Previously I was able to successfully compile stuff with just the VACPP environment enabled. But these were rather simplistic (my attempts at coding). This does not work for the bigger projects. So I needed to merge the VACPP & OS2_Toolkit stuff and exclude the GCC stuff that's sitting in /usr/include. That took a while to sort out, but that's not an issue with DISKIO, rather my own configuration.

Big part of this is that I rely on VisualSlickEdit as my IDE and the concept of PROJECTS. Each one can be defined as having it's own environment, so you can certainly build a VACPP project, a GCC project, etc, but all of these need to have the appropriate (and correct LOL) setups. I am totally expecting this effort though, but when you start with something new (such as DISKIO) it's hard to figure out what compile error is coming from a bad makefile, a bad source code, or a bad environment setup!!!

Therefore, what does work for me now is using the following environment setup to build with:

Code: [Select]
@ECHO OFF
SET CXXMAIN=G:\code\tools\Ibmcpp
SET TKMAIN=g:\code\tools\toolkit
SET GCCMAIN=g:\usr

SET INCLUDE=%TKMAIN%\H\ARPA;%TKMAIN%\H\NET;%TKMAIN%\H\NETINET;%TKMAIN%\H\NETNB;%TKMAIN%\H\RPC;%TKMAIN%\SPEECH\H;%TKMAIN%\H\GL;%TKMAIN%\H;%INCLUDE%

SET INCLUDE=%TKMAIN%\H\LIBC;%TKMAIN%\H\LIBC\SYS;%TKMAIN%\H\MACHINE;%TKMAIN%\H\PROTOCOL;%TKMAIN%\H\RPC;%TKMAIN%\H\STACK16;%TKMAIN%\H\SYS;%INCLUDE%

rem SET INCLUDE=%GCCMAIN%\INCLUDE;%INCLUDE%

rem ***********************************************************
rem IBM C and C++ Compilers for OS/2 environment variable settings
rem Licensed Materials - Property of IBM
rem (C) Copyright IBM Corp. 1991, 1997   All Rights Reserved
rem ***********************************************************

SET BEGINLIBPATH=%CXXMAIN%\DLL;%BEGINLIBPATH%
SET DPATH=%CXXMAIN%\HELP;%CXXMAIN%\LOCALE;%DPATH%
SET HELP=%CXXMAIN%\HELP;%HELP%
SET IPFC=%CXXMAIN%\BIN;%IPFC%
SET LIB=%CXXMAIN%\LIB;%LIB%
SET CPP_DBG_LANG=CPP
SET LANG=en_us
SET NLSPATHTEMP=%CXXMAIN%\MSG\%%N
SET NLSPATH=%NLSPATHTEMP%;%NLSPATH%
SET NLSPATHTEMP=
SET PATH=%CXXMAIN%\BIN;%PATH%

/* Kick off the NMAKE app */
g:\code\tools\toolkit\bin\nmake32.exe /a /f %1
exit

This is the result of the largely DEFAULT VACPP 3.65 install along with the grafted updates to the OS2_Toolkit that have been released by netlabs over the years.
« Last Edit: December 27, 2020, 06:12:04 pm by Dariusz Piatkowski »

Dave Yeo

  • Hero Member
  • *****
  • Posts: 5339
  • Karma: +126/-1
    • View Profile
Re: DISKIO - updated version in need of TEST
« Reply #19 on: December 27, 2020, 09:30:18 pm »
OK, I should revisit the VACPP 3.08 setup, probably screwed up in adding the toolkit. BTW, Gnumake seemed to work here.
For OpenWatcom, I have this to set things up,
Code: [Select]
@echo off
echo Open Watcom Build Environment
SET WATCOM=g:\WATCOM
SET PATH=%WATCOM%\BINP;%WATCOM%\BINW;%PATH%
SET BEGINLIBPATH=%WATCOM%\BINP\DLL;%BEGINLINPATH%
SET INCLUDE=%WATCOM%\H;%WATCOM%\H\OS2;%INCLUDE%
SET LIB=%WATCOM%\lib386;%WATCOM%\lib386\os2;%LIB%
SET EDPATH=%WATCOM%\EDDAT
SET WIPFC=%WATCOM%\WIPFC

And running wmake -f Watcom.mak (after the above mentioned patch) produces this output,
Code: [Select]
Open Watcom Make Version 2.0beta1 Limited Availability
Portions Copyright (c) 1988-2002 Sybase, Inc. All Rights Reserved.
Source code is available under the Sybase Open Watcom Public License.
See http://www.openwatcom.org/ for details.
WCC386 -bm -bt=os2v2 -e60 -6r -i.\; -oabhiklmnrt -s -w5 -ze -zdp -zq -zfp -zgp -zp1 -d2 -dOS2TMR -dOS2 -fodiskio.obj diskio.c
diskio.c(378): Warning! W131: No prototype found for function '_endthread'
diskio.c(383): Warning! W202: Symbol 'nCnt' has been defined, but not referenced
diskio.c(383): Warning! W202: Symbol 'nTrack' has been defined, but not referenced
diskio.c(476): Warning! W131: No prototype found for function '_beginthread'
diskio.c(7): Warning! W202: Symbol 'rcsid' has been defined, but not referenced
diskio.c(125): Warning! W202: Symbol 'nSemCount' has been defined, but not referenced
WCC386 -bm -bt=os2v2 -e60 -6r -i.\; -oabhiklmnrt -s -w5 -ze -zdp -zq -zfp -zgp -zp1 -d2 -dOS2TMR -dOS2 -fodiskacc2.obj diskacc2.c
diskacc2.c(386): Warning! W202: Symbol 'status' has been defined, but not referenced
diskacc2.c(384): Warning! W202: Symbol 'i' has been defined, but not referenced
diskacc2.c(9): Warning! W202: Symbol 'rcsrev' has been defined, but not referenced
diskacc2.c(7): Warning! W202: Symbol 'rcsid' has been defined, but not referenced
WCC386 -bm -bt=os2v2 -e60 -6r -i.\; -oabhiklmnrt -s -w5 -ze -zdp -zq -zfp -zgp -zp1 -d2 -dOS2TMR -dOS2 -fodhry_1.obj dhry_1.c
dhry_1.c(153): Warning! W131: No prototype found for function 'Func_2'
dhry_1.c(159): Warning! W131: No prototype found for function 'Proc_7'
dhry_1.c(164): Warning! W131: No prototype found for function 'Proc_8'
dhry_1.c(173): Warning! W131: No prototype found for function 'Proc_6'
WCC386 -bm -bt=os2v2 -e60 -6r -i.\; -oabhiklmnrt -s -w5 -ze -zdp -zq -zfp -zgp -zp1 -d2 -dOS2TMR -dOS2 -fodhry_2.obj dhry_2.c
dhry_2.c(39): Warning! W131: No prototype found for function 'Func_3'
WCC386 -bm -bt=os2v2 -e60 -6r -i.\; -oabhiklmnrt -s -w5 -ze -zdp -zq -zfp -zgp -zp1 -d2 -dOS2TMR -dOS2 -focpuperf.obj cpuperf.c
WLINK form os2 lx option int, dosseg, map, eliminate, mang, tog sort global @diskio.def
** EXPERIMENTAL (HLL) ** Open Watcom Linker Version 2.0beta1 Limited Availability
Portions Copyright (c) 1985-2002 Sybase, Inc. All Rights Reserved.
Source code is available under the Sybase Open Watcom Public License.
See http://www.openwatcom.org/ for details.
loading object files
searching libraries
creating map file
creating an OS/2 linear extended executable

No show stopping warnings. I did adjust the flags a bit trying to produce a debug build but it didn't change the warnings.

I have run into what seems like a major OS/2 bug. If I have my USB3 HD plugged into my USB C adapter and try to run diskio (and sysbench), the system locks up hard while benchmarking the first or second hard drive, the USB one is number 5 or 6. This is repeatable.
Interestingly I tried it with the 1 TB JFS partition marked dirty after the crash and it worked though the USB 3 drive seemed to give USB 2 speeds, about 22 MB/s whereas copying an ISO I see 90+ MB/s.
Probably worth opening an issue at some point.

Andreas Schnellbacher

  • Hero Member
  • *****
  • Posts: 827
  • Karma: +14/-0
    • View Profile
Re: DISKIO - updated version in need of TEST
« Reply #20 on: August 12, 2022, 11:02:35 pm »
This is a reposting of my message to AN Testers from today.

Code: [Select]
epm: {0}[I:\Download\sysutil\diskio] diskio
DISKIO - Fixed Disk Benchmark, Version 1.20
(C) 1994-1998 Kai Uwe Rommel
(C) 2004 madded2

    2020 Dariusz Piatkowski

Number of fixed disks: 9
Number of CD-ROM drives: 1

Dhrystone 2.1 C benchmark routines (C) 1988 Reinhold P. Weicker
Dhrystone benchmark for this CPU: 5716722 runs/sec

Hard disk 1: 255 sides, 29185 cylinders, 63 sectors per track = 228934 MB
Drive cache/bus transfer rate: 106195 k/sec

Data transfer rate on cylinder 0   : 146183 k/sec

Data transfer rate on cylinder 29183: 191315 k/sec

CPU usage by full speed disk transfers: 11%

Average latency time: 0.1 ms

Average data access time: Disk read error.
Multithreaded disk I/O (4 threads):
 133148 k/sec, 9% CPU usage


Hard disk 2: 12 sides, 512 cylinders, 9 sectors per track = 27 MB
Drive cache/bus transfer rate: Disk read error.
Data transfer rate on cylinder 0   : Disk read error.
Data transfer rate on cylinder 510 : Disk read error.
CPU usage by full speed disk transfers: Disk read error.
Average latency time: Disk read error.
Average data access time: Disk read error.
Multithreaded disk I/O (4 threads):
SYS1808:
The process has stopped.  The software diagnostic
code (exception code) is  009B.

epm: {99}[I:\Download\sysutil\diskio]
Hard disk 1 is a relative old SSD: A (partly faulty) Kingston
SKC 300 S37A (240 GB).
Haven't tried with the faster Samsung 860 EVO (500 GB) so far.

Hard disk 2 doesn't exist.

This seems to give better values for SSDs than Sysbench.
« Last Edit: August 12, 2022, 11:12:24 pm by Andreas Schnellbacher »

Remy

  • Hero Member
  • *****
  • Posts: 872
  • Karma: +14/-1
    • View Profile
Re: DISKIO - updated version in need of TEST
« Reply #21 on: August 15, 2022, 08:53:45 pm »
Does it have a sense to do diskbench on SSD with not aligned partition ?

Dave Yeo

  • Hero Member
  • *****
  • Posts: 5339
  • Karma: +126/-1
    • View Profile
Re: DISKIO - updated version in need of TEST
« Reply #22 on: August 16, 2022, 01:02:44 am »
Diskio reads tracks and ignores partitions and file systems. Along with the rest of OS/2, it does expect 512 byte sectors but i doubt that matters.

Dariusz Piatkowski

  • Hero Member
  • *****
  • Posts: 1421
  • Karma: +28/-0
    • View Profile
Re: DISKIO - updated version in need of TEST
« Reply #23 on: December 14, 2024, 05:15:13 pm »
UPDATE!  ;)
========

Allow me to pontificate here for a little first as that will properly set the context of the DISKIO upgrade.

I've recently 'upgraded' to a new'er CPU - LOL, seriously, from 6-core AMD Phenom II X6 to 8-core AMD FX-8370, which being a hardware "let's have fun" kind of a guy is now massively overclocked to 5GHz and happily churning away!

Anyways, I was expecting to gain some performance and as it turned out the various benchmark scores across the board were higher. However strangely enough (and I still haven't figured this one out yet, although I suspect it's the chipset difference - 890FXA vs 990FXA) my HD xfer rates actually took a bit of a dive.

Sooo...out came the DISKIO source and I picked up where we left off last time.

Subsequently, I now present you with DISKIO v1.25 (http://darcio.no-ip.org/os2/diskio/diskio-v1.25-Dec_2024.zip), the changes are:

 * Revision 1.25  2024/12/13 13:20:393  dspiatkowski
 * - implemented some code visual clean-up and re-organization
 * - introduced the stepped multi-thread benchmark from 1 to MAXTHREAD = CPUCOUNT
 * - introduced the optional user defined test duration, DEFAULT=5 secs

In short, I attempted to close out some of the loose ends we had last time around, although I suspect there are at least a few more places that I need to re-visit, so expect to see some errors with very fast systems.

Further on, DISKIO in it's multithreaded test had a static define of 4-threads...I thought to myself: well, OK, but if I am genuinely assessing the capability of my system I would want to maximize what it can do. So on SMP machines where more than 4 CPU cores are available it would make sense that I might want to run multiple disk threads beyond just the 4 that DISKIO currently defines.

I therefore re-wrote the multithreaded logic to test from THREAD=1 to THREAD=maxcpu.

That gives you a bit of a "how scalable is my machine" kind of an assessment as you observe the throughput rates shift when multiple threads start running concurrently.

Outside of this, I found that the default 'test duration' of 10 secs was causing us some problems in the past (again, on very fast machines), and so I had previously dropped that to 5 secs, but to be honest while that's an OK default I should not be telling YOU how long to run a test for, that should be YOUR decision.

So there is an extra parameter now, see '-t x' where the 'x' is the duration of the test, so '-t 10' would run all the tests for 10 secs.

Caveats
1) I am finding that with my RAMDISK I still occasionally see "Disk read error" (see sample output below) so I suspect I have some variable overflow somewhere in there as the RAMDISK setup is very fast, as one would expect it to be.

2) The USB attached storage devices, which previously caused some problems will continue to do so. I did not include any logic to deal with a device that is reporting itself as a storage device and yet has no actual storage media loaded/attached. (to-do list)

3) The Dhrystone CPU benchmark needs updates to deal with fast CPUs. (to-do list)

Here is a sample run for my RAMDISK and Evo 850 SSD storage devices:

Code: [Select]
[G:\CODE\source\os2\diskio]diskio -hd 1 2 -t 1
DISKIO - Fixed Disk Benchmark, Version 1.25
(C) 1994-1998 Kai Uwe Rommel
(C)      2004 madded2
    2020-2024 Dariusz Piatkowski

Number of fixed disks: 9
Number of CD-ROM drives: 1

Dhrystone 2.1 C benchmark routines (C) 1988 Reinhold P. Weicker
Dhrystone benchmark for this CPU: 6813001 runs/sec

Hard disk 1: 255 sides, 1142 cylinders, 63 sectors per track = 8958 MB

Drive cache/bus transfer rate:          669608 k/sec
Data transfer rate on cylinder 0      : 640079 k/sec
Data transfer rate on cylinder 1140   : 639079 k/sec
CPU usage by full speed disk transfers: 15%
Average latency time:                   0.0 ms
Average data access time:               Disk read error.

Multithreaded disk I/O
        1  thread:                      635049 k/sec, 14% CPU usage
        2 threads:                      268509 k/sec, 7% CPU usage
        3 threads:                      506938 k/sec, 14% CPU usage
        4 threads:                      572116 k/sec, 17% CPU usage
        5 threads:                      473047 k/sec, 15% CPU usage
        6 threads:                      476042 k/sec, 20% CPU usage
        7 threads:                      527724 k/sec, 30% CPU usage
        8 threads:                      452431 k/sec, 33% CPU usage

Hard disk 2: 255 sides, 30401 cylinders, 63 sectors per track = 238472 MB

Drive cache/bus transfer rate:          128555 k/sec
Data transfer rate on cylinder 0      : 264076 k/sec
Data transfer rate on cylinder 30399  : 239458 k/sec
CPU usage by full speed disk transfers: 6%
Average latency time:                   0.1 ms
Average data access time:               0.1 ms

Multithreaded disk I/O
        1  thread:                      112556 k/sec, 3% CPU usage
        2 threads:                      111679 k/sec, 2% CPU usage
        3 threads:                      108675 k/sec, 4% CPU usage
        4 threads:                      107708 k/sec, 3% CPU usage
        5 threads:                      107778 k/sec, 3% CPU usage
        6 threads:                      107738 k/sec, 4% CPU usage
        7 threads:                      107084 k/sec, 4% CPU usage
        8 threads:                      107028 k/sec, 6% CPU usage

Concurrent full speed reads on 2 hard disks
Combined throughput:                    666164 k/sec, 22% CPU usage

The ZIP file has the standard and DEBUG versions. As before, if you are seeing funny stuff from the standard build, run the DEBUG, capture the outputs and send it my way please.
« Last Edit: December 14, 2024, 06:29:10 pm by Dariusz Piatkowski »

roberto

  • Hero Member
  • *****
  • Posts: 826
  • Karma: +3/-6
    • View Profile
Re: DISKIO - updated version in need of TEST
« Reply #24 on: December 16, 2024, 06:58:56 pm »
Hello Dariusz
My test:
Code: [Select]

[D:\]cd D:\diskio125

[D:\diskio125]diskio
DISKIO - Fixed Disk Benchmark, Version 1.25
(C) 1994-1998 Kai Uwe Rommel
(C)      2004 madded2
    2020-2024 Dariusz Piatkowski

Number of fixed disks: 10
Number of CD-ROM drives: 2

Dhrystone 2.1 C benchmark routines (C) 1988 Reinhold P. Weicker
Dhrystone benchmark for this CPU: 3307018 runs/sec

Hard disk 1: 255 sides, 14593 cylinders, 63 sectors per track = 114470 MB

Drive cache/bus transfer rate:          101023 k/sec
Data transfer rate on cylinder 0      : 116343 k/sec
Data transfer rate on cylinder 14591  : 241957 k/sec
CPU usage by full speed disk transfers: 0%
Average latency time:                   0.1 ms
Average data access time:               0.1 ms

Multithreaded disk I/O
        1  thread:                      116510 k/sec, 0% CPU usage
        2 threads:                      109296 k/sec, 0% CPU usage
        3 threads:                      108393 k/sec, 0% CPU usage
        4 threads:                      108952 k/sec, 0% CPU usage
        5 threads:                      109710 k/sec, 0% CPU usage
        6 threads:                      110312 k/sec, 0% CPU usage
        7 threads:                      110657 k/sec, 0% CPU usage
        8 threads:                      110428 k/sec, 0% CPU usage

Hard disk 2: 255 sides, 61769 cylinders, 127 sectors per track = 976752 MB

Drive cache/bus transfer rate:          165832 k/sec
Data transfer rate on cylinder 0      : 404224 k/sec
Data transfer rate on cylinder 61767  : 407399 k/sec
CPU usage by full speed disk transfers: 0%
Average latency time:                   0.0 ms
Average data access time:               0.2 ms

Multithreaded disk I/O
        1  thread:                      170925 k/sec, 0% CPU usage
        2 threads:                      161234 k/sec, 0% CPU usage
        3 threads:                      158390 k/sec, 0% CPU usage
        4 threads:                      158535 k/sec, 0% CPU usage
        5 threads:                      158018 k/sec, 0% CPU usage
        6 threads:                      158656 k/sec, 0% CPU usage
        7 threads:                      156967 k/sec, 0% CPU usage
        8 threads:                      157459 k/sec, 0% CPU usage

Hard disk 3: 12 sides, 512 cylinders, 9 sectors per track = 27 MB

Drive cache/bus transfer rate: Disk read error.
Data transfer rate on cylinder 0      : Disk read error.
Data transfer rate on cylinder 510    : Disk read error.
CPU usage by full speed disk transfers: Disk read error.
Average latency time: Disk read error.
Average data access time:               Disk read error.

Multithreaded disk I/O
        1  thread: Disk read error.

SYS1808:
The process has stopped.  The software diagnostic
code (exception code) is  009B.

[D:\diskio125]

popuplog.os2

12-16-2024  18:45:31  SYS3184  PID 0054  TID 0001  Slot 0086
D:\DISKIO125\DISKIO.EXE
c000009b
0002258d
EAX=00000000  EBX=00000000  ECX=00000000  EDX=00000000
ESI=00000000  EDI=00000000 
DS=0053  DSACC=d0f3  DSLIM=bfffffff 
ES=0053  ESACC=d0f3  ESLIM=bfffffff 
FS=150b  FSACC=00f3  FSLIM=00000030
GS=0000  GSACC=****  GSLIM=********
CS:EIP=005b:0002258d  CSACC=d0df  CSLIM=bfffffff
SS:ESP=0053:000b3878  SSACC=d0f3  SSLIM=bfffffff
EBP=000b389c  FLG=00210246

DISKIO.EXE 0002:0000258d
Disk1 is win10, disk2 is Arcaos

Saludos

Dariusz Piatkowski

  • Hero Member
  • *****
  • Posts: 1421
  • Karma: +28/-0
    • View Profile
Re: DISKIO - updated version in need of TEST
« Reply #25 on: December 17, 2024, 03:26:07 am »
Hello Roberto!

Thank you for testing and the feedback.

My test:
Code: [Select]
[D:\diskio125]diskio
DISKIO - Fixed Disk Benchmark, Version 1.25
Dhrystone 2.1 C benchmark routines (C) 1988 Reinhold P. Weicker
Dhrystone benchmark for this CPU: 3307018 runs/sec

Hmm, seems like low CPU score, what are you running? If that's a fast CPU I think we may be getting an overflow in the benchmark code, on my TO-DO list.

Code: [Select]
Hard disk 1: 255 sides, 14593 cylinders, 63 sectors per track = 114470 MB

Drive cache/bus transfer rate:          101023 k/sec
Data transfer rate on cylinder 0      : 116343 k/sec
Data transfer rate on cylinder 14591  : 241957 k/sec
CPU usage by full speed disk transfers: 0%
Average latency time:                   0.1 ms
Average data access time:               0.1 ms

Multithreaded disk I/O
        1  thread:                      116510 k/sec, 0% CPU usage
        2 threads:                      109296 k/sec, 0% CPU usage
        3 threads:                      108393 k/sec, 0% CPU usage
        4 threads:                      108952 k/sec, 0% CPU usage
        5 threads:                      109710 k/sec, 0% CPU usage
        6 threads:                      110312 k/sec, 0% CPU usage
        7 threads:                      110657 k/sec, 0% CPU usage
        8 threads:                      110428 k/sec, 0% CPU usage

So CPU is an 8-core chip, yes?

Interesting that its showing '0% CPU usage', I mean great, but that just seem like maybe we have a side-effect of showing whole numbers only and no decimal places for the 'CPU Usage'.

Can you get me a debug-run on just that drive please?

Code: [Select]
Hard disk 3: 12 sides, 512 cylinders, 9 sectors per track = 27 MB

Drive cache/bus transfer rate: Disk read error.
Data transfer rate on cylinder 0      : Disk read error.
Data transfer rate on cylinder 510    : Disk read error.
CPU usage by full speed disk transfers: Disk read error.
Average latency time: Disk read error.
Average data access time:               Disk read error.

Multithreaded disk I/O
        1  thread: Disk read error.

SYS1808:
The process has stopped.  The software diagnostic
code (exception code) is  009B.

Yup, USB devices...I am looking at ways of checking whether the storage devices that are identified by DISKIO at the start are actually usable, before the attempt to benchmark them actually starts.

Dave Yeo

  • Hero Member
  • *****
  • Posts: 5339
  • Karma: +126/-1
    • View Profile
Re: DISKIO - updated version in need of TEST
« Reply #26 on: December 17, 2024, 03:55:17 am »
Hi Dariusz, I get results more like Roberto, though it usually doesn't get as far here before crashing,
Code: [Select]
DISKIO - Fixed Disk Benchmark, Version 1.25
(C) 1994-1998 Kai Uwe Rommel
(C)      2004 madded2
    2020-2024 Dariusz Piatkowski

Number of fixed disks: 16
Number of CD-ROM drives: 2

Dhrystone 2.1 C benchmark routines (C) 1988 Reinhold P. Weicker
Dhrystone benchmark for this CPU: 148719 runs/sec

Hard disk 1: 255 sides, 60801 cylinders, 63 sectors per track = 476937 MB

Drive cache/bus transfer rate:          166465 k/sec
Data transfer rate on cylinder 0      : 332980 k/sec
Data transfer rate on cylinder 60799  : 331016 k/sec
CPU usage by full speed disk transfers: 8%
Average latency time:                   0.0 ms
Average data access time:               Disk read error.

Multithreaded disk I/O
        1  thread:
is logged and then
Code: [Select]
SYS1808:
The process has stopped.  The software diagnostic
code (exception code) is  009B.

The debug build exits here after the CPU benchmark, which varies widely on a quiet system and once locked the computer hard.
This is a I5-7500@3.5Ghz with Nvme and  SSD drives.
Perhaps a SMP issue?
Running the original also crashes,
Code: [Select]
DISKIO - Fixed Disk Benchmark, Version 1.18z
(C) 1994-1998 Kai Uwe Rommel
(C) 2004 madded2

Number of fixed disks: 16
Number of CD-ROM drives: 2

Dhrystone 2.1 C benchmark routines (C) 1988 Reinhold P. Weicker
Dhrystone benchmark for this CPU: 7461002 runs/sec

Hard disk 1: 255 sides, 60801 cylinders, 63 sectors per track = 476937 MB
Drive cache/bus transfer rate: 150517 k/sec
Data transfer rate on cylinder 0   : -155262 k/sec
Data transfer rate on cylinder 60799: -144451 k/sec
CPU usage by full speed disk transfers: 44%
Average data access time: Disk read error.
Multithreaded disk I/O (4 threads): SYS1808:
The process has stopped.  The software diagnostic
code (exception code) is  009B.

An earlier build from you got further,
Code: [Select]
DISKIO - Fixed Disk Benchmark, Version 1.20
(C) 1994-1998 Kai Uwe Rommel
(C) 2004 madded2

    2020 Dariusz Piatkowski

Number of fixed disks: 16
Number of CD-ROM drives: 2

Dhrystone 2.1 C benchmark routines (C) 1988 Reinhold P. Weicker
Dhrystone benchmark for this CPU: 8660078 runs/sec

Hard disk 1: 255 sides, 60801 cylinders, 63 sectors per track = 476937 MB
Drive cache/bus transfer rate: 146900 k/sec

Data transfer rate on cylinder 0   : 285680 k/sec

Data transfer rate on cylinder 60799: 287686 k/sec

CPU usage by full speed disk transfers: 50%

Average latency time: 0.0 ms

Average data access time: Disk read error.
Multithreaded disk I/O (4 threads):
 221010 k/sec, 46% CPU usage


Hard disk 2: 255 sides, 583 cylinders, 63 sectors per track = 4573 MB
Drive cache/bus transfer rate: 24411 k/sec

Data transfer rate on cylinder 0   : 22839 k/sec

Data transfer rate on cylinder 581 : 19798 k/sec

CPU usage by full speed disk transfers: 48%

Average latency time: 0.1 ms

Average data access time: Disk read error.
Multithreaded disk I/O (4 threads):
 24381 k/sec, 50% CPU usage


Hard disk 3: 255 sides, 60322 cylinders, 127 sectors per track = 953871 MB
Drive cache/bus transfer rate: 39907 k/sec

Data transfer rate on cylinder 0   : Disk read error.
Data transfer rate on cylinder 60320: 433087 k/sec

CPU usage by full speed disk transfers: Disk read error.
Average latency time: 0.0 ms

Average data access time: Disk read error.
Multithreaded disk I/O (4 threads): Disk read error.

 40497 k/sec, 62% CPU usage


Hard disk 4: 255 sides, 60322 cylinders, 127 sectors per track = 953871 MB
Drive cache/bus transfer rate: 48704 k/sec

Data transfer rate on cylinder 0   : Disk read error.
Data transfer rate on cylinder 60320: 610275 k/sec

CPU usage by full speed disk transfers: Disk read error.
Average latency time:
SYS1808:
The process has stopped.  The software diagnostic
code (exception code) is  009B.

There's entries in popuplog.os2 for each crash.


Dave Yeo

  • Hero Member
  • *****
  • Posts: 5339
  • Karma: +126/-1
    • View Profile
Re: DISKIO - updated version in need of TEST
« Reply #27 on: December 17, 2024, 04:17:22 am »
I remembered that you don't run AcpiDaemon, so I killed it and retested, got further before crashing. Then tried without redirecting stdout, stderr (diskio 2>&1 | tee diskio.log) and it finished, of course the results scrolled off the screen
Even doing "diskio > diskio.log" crashes as above.
Running without AcpiDaemon here also sees the CPU temp at about 65C compared to 38C with it running and testing diskio.

Rich Walsh

  • Sr. Member
  • ****
  • Posts: 398
  • Karma: +30/-0
  • ONU! (OS/2 is NOT Unix!)
    • View Profile
Re: DISKIO - updated version in need of TEST
« Reply #28 on: December 17, 2024, 06:43:07 am »
Code: [Select]
Number of fixed disks: 17
Number of CD-ROM drives: 1

Dhrystone 2.1 C benchmark routines (C) 1988 Reinhold P. Weicker
Dhrystone benchmark for this CPU: -567273196 runs/sec

Hard disk 1: 255 sides, 62261 cylinders, 63 sectors per track = 488390 MB

Drive cache/bus transfer rate:
SYS1808:
The process has stopped.  The software diagnostic
code (exception code) is  009B.

Even if it didn't crash with a "divide by zero" error (009B), 'Diskio' would be unlikely to provide useful info about my disks. Both of them are GPT and are normally *hidden* from the system by 'gpt.flt'.

What OS/2 sees are a bunch of _emulated_ MBR disks, one for each mounted partition plus a few spares that appear to be unpartitioned. Doing a speed test on a phony disk that refers to some partition somewhere on one of the physical disks wouldn't be overly informative. In any case, I don't think you can access them using the Physical Disk IOCTLs that 'Diskio' depends on, so we'll probably never know.

FWIW... GPT disks can be made visible, though I'm not sure how accessible they are. I look forward to trying 'Diskio' again with the disks visible once the current crop of issues is resolved.

Dave Yeo

  • Hero Member
  • *****
  • Posts: 5339
  • Karma: +126/-1
    • View Profile
Re: DISKIO - updated version in need of TEST
« Reply #29 on: December 17, 2024, 08:02:11 am »

Even if it didn't crash with a "divide by zero" error (009B), 'Diskio' would be unlikely to provide useful info about my disks. Both of them are GPT and are normally *hidden* from the system by 'gpt.flt'.

What OS/2 sees are a bunch of _emulated_ MBR disks, one for each mounted partition plus a few spares that appear to be unpartitioned. Doing a speed test on a phony disk that refers to some partition somewhere on one of the physical disks wouldn't be overly informative. In any case, I don't think you can access them using the Physical Disk IOCTLs that 'Diskio' depends on, so we'll probably never know.

FWIW... GPT disks can be made visible, though I'm not sure how accessible they are. I look forward to trying 'Diskio' again with the disks visible once the current crop of issues is resolved.

Seems to kind of work on GPT disk here, each partition presents as a device the full size of the device, eg for my 1TB NVMe
Code: [Select]
Hard disk 3: 255 sides, 60322 cylinders, 127 sectors per track = 953871 MB

Drive cache/bus transfer rate:          137487 k/sec
Data transfer rate on cylinder 0      : Disk read error.
Data transfer rate on cylinder 60320  : 71482 k/sec
CPU usage by full speed disk transfers: Disk read error.
Average latency time:                   0.0 ms
Average data access time:               Disk read error.

Multithreaded disk I/O
        1  thread:                      6654 k/sec, 28% CPU usage
        2 threads:                      762685 k/sec, 28% CPU usage
        3 threads: Disk read error.
                        896092 k/sec, 20% CPU usage
        4 threads: Disk read error.
                        1889132 k/sec, 26% CPU usage

Hard disk 4: 255 sides, 60322 cylinders, 127 sectors per track = 953871 MB

Drive cache/bus transfer rate:          148253 k/sec
Data transfer rate on cylinder 0      : Disk read error.
Data transfer rate on cylinder 60320  : 32923 k/sec
CPU usage by full speed disk transfers: Disk read error.
Average latency time:                   0.0 ms
Average data access time:               Disk read error.

Multithreaded disk I/O
        1  thread: Disk read error.
                        158947 k/sec, 35% CPU usage
        2 threads: Disk read error.
                        166172 k/sec, 35% CPU usage
        3 threads: Disk read error.
                        156057 k/sec, 35% CPU usage
        4 threads: Disk read error.
                        162560 k/sec, 34% CPU usage

Hard disk 5: 255 sides, 60322 cylinders, 127 sectors per track = 953871 MB

Drive cache/bus transfer rate:          149314 k/sec
Data transfer rate on cylinder 0      : Disk read error.
Data transfer rate on cylinder 60320  :
The external process was cancelled by a Ctrl+Break or another process.

First try locked up the machine so I did CTRL-C when I had enough info. The numbers are quite a bit worse then the MBR SSD along with the Disk read errors which seem to vary.