Author Topic: FeatherNotes for OS/2  (Read 31660 times)

Martin Iturbide

  • OS2World NewsMaster
  • Global Moderator
  • Hero Member
  • *****
  • Posts: 4668
  • Karma: +41/-1
  • Your Friend Wil Declares...
    • View Profile
    • Martin's Personal Blog
Re: FeatherNotes for OS/2
« Reply #30 on: June 25, 2023, 10:07:03 pm »
Hi Mike

Give it try.
Download FeatherNotes-1.1.0-0.oc00.pentium4.rpm and run "yum install FeatherNotes-1.1.0-0.oc00.pentium4.rpm" and see what shows up. I guess it will coexists, but let us know if it shows any error.

Regards
Martin Iturbide
OS2World NewsMaster
... just share the dream.

andreas

  • Jr. Member
  • **
  • Posts: 67
  • Karma: +4/-0
    • View Profile
Re: FeatherNotes for OS/2
« Reply #31 on: July 03, 2023, 09:52:07 pm »
I have a problem with some letters that are not stored correctly. Input seems ok, but after storing and reopening the file the German Umlaute (äöü) and ß are not recognized anymore. Is there a way to chage that?

Martin Iturbide

  • OS2World NewsMaster
  • Global Moderator
  • Hero Member
  • *****
  • Posts: 4668
  • Karma: +41/-1
  • Your Friend Wil Declares...
    • View Profile
    • Martin's Personal Blog
Re: FeatherNotes for OS/2
« Reply #32 on: July 03, 2023, 10:36:52 pm »
Hi Andreas.

I confirm your finding with some special characters we use in the Spanish language.

Regards

Update: Corrected attachment
« Last Edit: July 03, 2023, 11:05:59 pm by Martin Iturbide »
Martin Iturbide
OS2World NewsMaster
... just share the dream.

Alex Taylor

  • Sr. Member
  • ****
  • Posts: 385
  • Karma: +5/-0
    • View Profile
Re: FeatherNotes for OS/2
« Reply #33 on: July 04, 2023, 12:38:08 am »
Looks as though it's saving the file in UTF-8 but opening it in the default system encoding (850).

Jochen Schäfer

  • Sr. Member
  • ****
  • Posts: 305
  • Karma: +27/-0
    • View Profile
Re: FeatherNotes for OS/2
« Reply #34 on: July 04, 2023, 10:55:40 am »
I will look at the issue.

Alex Taylor

  • Sr. Member
  • ****
  • Posts: 385
  • Karma: +5/-0
    • View Profile
Re: FeatherNotes for OS/2
« Reply #35 on: July 04, 2023, 02:51:56 pm »
I glanced briefly at the file open/save code in fn.cpp; it doesn't look as though the QTextStream object is setting the codec anywhere. 

Are you building with Qt5 or Qt6? Apparently, the text codec logic changed radically between the two versions.

Martin Iturbide

  • OS2World NewsMaster
  • Global Moderator
  • Hero Member
  • *****
  • Posts: 4668
  • Karma: +41/-1
  • Your Friend Wil Declares...
    • View Profile
    • Martin's Personal Blog
Re: FeatherNotes for OS/2
« Reply #36 on: July 04, 2023, 03:00:44 pm »
Hi Alex
Are you building with Qt5 or Qt6? Apparently, the text codec logic changed radically between the two versions.
For what I see with PMDLL, FeatherNotes is compiled with Qt5.
Regards
Martin Iturbide
OS2World NewsMaster
... just share the dream.

Jochen Schäfer

  • Sr. Member
  • ****
  • Posts: 305
  • Karma: +27/-0
    • View Profile
Re: FeatherNotes for OS/2
« Reply #37 on: July 06, 2023, 11:25:58 am »
Looks as though it's saving the file in UTF-8 but opening it in the default system encoding (850).
Yes, that's correct as per Qt5 documentation. The code is certainly under the assumption, that the default nowadays is UTF-8.
I fixed the issue for OS/2 and made a new release, which can be downloaded on my Github page.

andreas

  • Jr. Member
  • **
  • Posts: 67
  • Karma: +4/-0
    • View Profile
Re: FeatherNotes for OS/2
« Reply #38 on: July 06, 2023, 02:46:45 pm »
thank you for fixing that so quickly. just tried it out. works well here.

But i found some other issue, related to the previous one. The €-Symbol is not recognized already while typing it...

andreas

  • Jr. Member
  • **
  • Posts: 67
  • Karma: +4/-0
    • View Profile
Re: FeatherNotes for OS/2
« Reply #39 on: July 06, 2023, 02:54:34 pm »
another question: is it possible to open a saved file directly with a double-click? i aleady connected the associations, but only the program opens, not the related file..

Jochen Schäfer

  • Sr. Member
  • ****
  • Posts: 305
  • Karma: +27/-0
    • View Profile
Re: FeatherNotes for OS/2
« Reply #40 on: July 06, 2023, 03:07:45 pm »
thank you for fixing that so quickly. just tried it out. works well here.

But i found some other issue, related to the previous one. The €-Symbol is not recognized already while typing it...
This is probably a QT5 issue. Can you create an issue here: https://github.com/bitwiseworks/qt5-os2/issues.

andreas

  • Jr. Member
  • **
  • Posts: 67
  • Karma: +4/-0
    • View Profile
Re: FeatherNotes for OS/2
« Reply #41 on: July 06, 2023, 03:17:27 pm »
did so..

Paul Smedley

  • Hero Member
  • *****
  • Posts: 2089
  • Karma: +159/-0
    • View Profile
Re: FeatherNotes for OS/2
« Reply #42 on: July 08, 2023, 11:06:50 am »
thank you for fixing that so quickly. just tried it out. works well here.

But i found some other issue, related to the previous one. The €-Symbol is not recognized already while typing it...
This is probably a QT5 issue. Can you create an issue here: https://github.com/bitwiseworks/qt5-os2/issues.

Qt6 has similar issues with 'special' characters. I wonder if code needs to be added or the Euro to https://github.com/bitwiseworks/qtbase-os2/blob/master/src/plugins/platforms/os2/qos2keymapper.cpp#L163

David McKenna

  • Hero Member
  • *****
  • Posts: 740
  • Karma: +24/-0
    • View Profile
Re: FeatherNotes for OS/2
« Reply #43 on: July 08, 2023, 02:11:05 pm »
 Browsing the code Paul linked to above, I saw this note:

            // The only known situation when KC_VIRTUALKEY is present but
            // vkey is zero is when Alt+Shift is pressed to switch the
            // keyboard layout state from latin to national and back.
            // It seems that this way the system informs applications about
            // layout changes: chm.chr is 0xF1 when the user switches
            // to the national layout (i.e. presses Alt + Left Shift)
            // and 0xF0 when he switches back (presses Alt + Right Shift).
            // We assume this and restore fs, vkey, scancode and chr accordingly.

 So maybe Andreas could try hitting the left <alt><shift> before trying to type a euro symbol?

Regards,

EDIT: looks like Feathernotes uses <alt><shift> to left and right justify text, so probably not gonna work unfortunately...
« Last Edit: July 08, 2023, 02:41:21 pm by David McKenna »

ivan

  • Hero Member
  • *****
  • Posts: 1552
  • Karma: +17/-0
    • View Profile
Re: FeatherNotes for OS/2
« Reply #44 on: July 08, 2023, 11:16:46 pm »
Has anyone looked at win95key to change/add characters, it allows me to do such things like having the euro symbol.