Hi.
I didn't liked the other issue.
Issue 2) The second issue is that there functions on CP1.INF that are also on the legacy (prcp.INF), but the CP1 function is not specified correctly. Which it also means that those CP1 functions have not been implemented, and only the legacy documentation should apply. right?
For example:
VioScrollUp from CP1.INF says:
ULONG TopRow; /* Top row to be scrolled. */
ULONG LeftCol; /* Left column to be scrolled. */
ULONG BotRow; /* Bottom row to be scrolled. */
ULONG RightCol; /* Right column to be scrolled. */
ULONG Lines; /* Number of lines. */
PBYTE Cell; /* Cell to be written. */
HVIO VioHandle; /* VIO presentation-space handle. */
APIRET rc; /* Return code. */
rc = VioScrollUp(TopRow, LeftCol, BotRow,
RightCol, Lines, Cell, VioHandle);
VioScrollUp from prcp.inf (legacy) says:
VioScrollUp (TopRow, LeftCol, BotRow, RightCol, Lines, Cell, VioHandle)
TopRow (USHORT) - input
LeftCol (USHORT) - input
BotRow (USHORT) - input
RightCol (USHORT) - input
Lines (USHORT) - input
Cell (PBYTE) - input
VioHandle (HVIO) - input
OS2TK45 has:
bseord.h:
/* VIOCALLS */
#define ORD_VIOSCROLLUP 7
bsesub.h
#define VioScrollUp VIO16SCROLLUP
...
#define VR_VIOSCROLLUP 0x00040000L
...
APIRET16 APIENTRY16 VioScrollUp (USHORT usTopRow,
USHORT usLeftCol,
USHORT usBotRow,
USHORT usRightCol,
USHORT cbLines,
PBYTE pCell,
HVIO hvio);
If you call VIOSCROLLUP but sending ULONG parameters (like CP1 says) will it not work?
Is there a way to confirm that CP1's VIOSCROLLUP (the new one) does not exists at all? Or what I posted is enough evidence? I'm not sure about it.
If it does not work, that would mean to me that I also need to document the legacy functions, and also put some warning on it that even that there is a "non-legacy function" you still need to use the legacy one because the newer one does not work. Does it makes sense?
I will need to think about it which will be a good way to document this on the CPI API Project.
Regards