OS2 World Community Forum

OS/2, eCS & ArcaOS - Technical => Applications => Topic started by: Paul Smedley on July 18, 2020, 11:23:54 am

Title: Subversion 1.14.0
Post by: Paul Smedley on July 18, 2020, 11:23:54 am
Hi guys,

I finally got a newer SVN client that 1.7.21 working on OS/2

Tested is the ability to retrieve repositories from http and https repositories and to commit simple changes.

That's about the extent of my current testing :)

For anyone feeling brave - http://smedley.id.au/tmp/subversion-1.14.0-os2-20200718.zip

Feedback appreciated

Cheers,

Paul
Title: Re: Subversion 1.14.0
Post by: Andreas Schnellbacher on July 18, 2020, 09:17:18 pm
Hi Paul,

I plan to test it next week. I'm currently using your version 1.7 without problems, so, I guess, database conversion won't happen again. Just give me some time.
Title: Re: Subversion 1.14.0
Post by: Paul Smedley on July 19, 2020, 01:18:57 am
Hi Andreas,

Note: you'll need to run 'svn upgrade' to upgrade the working copy to the metadata format used by 1.14.0

I suggest taking a backup first just in case there are bugs in 1.14.0 that cause you to need to revert back to 1.7.x

Cheers,

Paul
Title: Re: Subversion 1.14.0
Post by: Dave Yeo on July 19, 2020, 04:15:51 am
Seems to be working fine here. Didn't do a checkout but rather an upgrade. Add, revert, status, diff, commit all work.
Title: Re: Subversion 1.14.0
Post by: Paul Smedley on July 19, 2020, 07:44:16 am
Seems to be working fine here. Didn't do a checkout but rather an upgrade. Add, revert, status, diff, commit all work.

Thanks Dave!

Some know issues so far:
- passwords echo to screen
- some screen output is messed up - looks line line break issues maybe...
Title: Re: Subversion 1.14.0
Post by: Dave Yeo on July 23, 2020, 07:00:51 am
A sample from Lewis always times out here, at least your latest stopped the APR timeout spam.
Code: [Select]
svn list -v --search "*.dlg" --search "*.rc" http://svn.netlabs.org/repos/cwmmclasses/branches/v2.9/classes/res/en/
Title: Re: Subversion 1.14.0
Post by: Paul Smedley on July 23, 2020, 09:05:21 am
A sample from Lewis always times out here, at least your latest stopped the APR timeout spam.
Code: [Select]
svn list -v --search "*.dlg" --search "*.rc" http://svn.netlabs.org/repos/cwmmclasses/branches/v2.9/classes/res/en/

This is potentially due to lack of wildcard support. Will try relinking with -Zarg-wilds tonight
Title: Re: Subversion 1.14.0
Post by: Andy Willis on July 24, 2020, 05:01:18 am
if run under sh, does the shell do the expansion and then work?
Just tested and expansion does occur under sh (as the shell is doing the expansion then).
Title: Re: Subversion 1.14.0
Post by: Dave Yeo on July 24, 2020, 06:58:06 am
if run under sh, does the shell do the expansion and then work?
Just tested and expansion does occur under sh (as the shell is doing the expansion then).

Still timeouts. Still it should be built with wildcard support.
Title: Re: Subversion 1.14.0
Post by: Paul Smedley on July 24, 2020, 11:42:14 am
if run under sh, does the shell do the expansion and then work?
Just tested and expansion does occur under sh (as the shell is doing the expansion then).

Still timeouts. Still it should be built with wildcard support.

Problem solved. I've been building debug builds. My debug ldflags omitted -Zwild-args for some reason. Fixed now and rebuilding.

I have things to do this evening, so will upload it in the morning (my time).

Cheers,

Paul
Title: Re: Subversion 1.14.0
Post by: Paul Smedley on July 24, 2020, 12:00:00 pm
It built quicker than I thought.... http://smedley.id.au/tmp/subversion-1.14.0-os2-20200724.zip

I didn't have time to confirm it fixes the wildcard issues, but I'm hoping....
Title: Re: Subversion 1.14.0
Post by: Andreas Schnellbacher on July 24, 2020, 06:12:38 pm
Wildcards may work now, but apparently there's a problem with starting an editor for log messages.

Here's what I did, starting with a repository converted with your version 1.7.21:

Code: [Select]
epm: G:\dev\netlabs\nepmd > svn status
svn: E155036: Please see the 'svn upgrade' command
svn: E155036: The working copy at 'G:/dev/netlabs/nepmd'
is too old (format 29) to work with client version '1.14.0 (r1876290)' (expects format 31). You need to upgrade the working copy first.

This was expected. I've first checked if I can reproduce the reported wildcard problems. That's with the old version 1.14.0 2020-07-18:

Code: [Select]
epm: G:\dev\netlabs\nepmd > svn upgrade
Upgraded '.'

epm: G:\dev\netlabs\nepmd\trunk\src\gui\common > svn ci *
svn: E720253: Error resolving case of '*'

OK, apparently confirmed. Now with the new version 1.14.0 2020-07-24:

Code: [Select]
epm: G:\dev\netlabs\nepmd\trunk\src\gui\common > svn ci *
svn: E205001: Try 'svn help commit' for more information
svn: E205001: Commit failed (details follow):
svn: E205001: Cannot invoke editor to get log message when non-interactive

In my file %HOME%\.subersion\config I have:

Code: [Select]
[helpers]
editor-cmd = epm /m

For comparison, here's how it works with 1.7.21 from my safety copy:

Code: [Select]
epm: G:\dev\netlabs\_nepmd-svn1.7\trunk\src\gui\common > svn ci *

A new editor window is opened synchronously (due to the config epm /m) with a tmp. file svn-commit.tmp:

Code: [Select]
--This line, and those below, will be ignored--

M    libreg.c
M    libreg.h
Title: Re: Subversion 1.14.0
Post by: Andreas Schnellbacher on July 25, 2020, 04:57:53 pm
1) The configuration of a text editor in %HOME%\.subversion\config, section [helpers], via editor-cmd doesn't seem to work at all. In a VIO env with CMD.EXE I always get tedit. In a PM env the call just doesn't work and leads to the error message I've reported above. Both work for me with 1.7.21.

2) The line breaks of messages doesn't work correctly. You have already mentioned this.
Code: [Select]
Log message unchanged or not specified
                                      (a)bort, (c)ontinue, (e)dit:
                                                                  a

3) EDIT: Not a bug: Path names seem to be case-sensitive:
Code: [Select]
[G:\dev\netlabs\nepmd-1.14\TRUNK\SRC\NETLABS\MACROS]svn ci *
svn: E155010: Commit failed (details follow):
svn: E155010: The node 'G:/dev/netlabs/nepmd-1.14/TRUNK/SRC/NETLABS'
was not found.
It works from the path in its real case:
Code: [Select]
[G:\dev\netlabs\nepmd-1.14\trunk\src\netlabs\macros]svn ci *
Note that apparently filenames can be specified in any case.

EDIT: The same happens with 1.7.21. Thanks to Steven.
Title: Re: Subversion 1.14.0
Post by: Paul Smedley on July 28, 2020, 11:26:23 am
Hi Andreas,

For the editor issue - http://smedley.id.au/tmp/subversion-1.14.0-os2-20200728.zip should work the same as  1.7.21

For the other items, I need to find some spare time to investigate.

Cheers,

Paul
Title: Re: Subversion 1.14.0
Post by: Andreas Schnellbacher on July 28, 2020, 07:29:56 pm
Hi Paul, it looks like you've packed the same svn.exe as before. (I've renamed them for this:)

Code: [Select]
epm: I:\Download\connect > svn-2020-07-24.exe --version
svn, version 1.14.0 (r1876290)
   compiled Jul 24 2020, 19:07:05 on i386-pc-os2-emx

epm: I:\Download\connect > svn-2020-07-28.exe --version
svn, version 1.14.0 (r1876290)
   compiled Jul 24 2020, 19:07:05 on i386-pc-os2-emx

Needless to say: It behaves the same as the old version.
Title: Re: Subversion 1.14.0
Post by: Paul Smedley on July 29, 2020, 09:39:00 am
Hi Andreas,

Hi Paul, it looks like you've packed the same svn.exe as before. (I've renamed them for this:)

Code: [Select]
epm: I:\Download\connect > svn-2020-07-24.exe --version
svn, version 1.14.0 (r1876290)
   compiled Jul 24 2020, 19:07:05 on i386-pc-os2-emx

epm: I:\Download\connect > svn-2020-07-28.exe --version
svn, version 1.14.0 (r1876290)
   compiled Jul 24 2020, 19:07:05 on i386-pc-os2-emx

Needless to say: It behaves the same as the old version.

The 'compiled' flag is set by configure - it's not a true compile date/time....

Title: Re: Subversion 1.14.0
Post by: Andreas Schnellbacher on July 29, 2020, 01:45:51 pm
The 'compiled' flag is set by configure - it's not a true compile date/time....
OK. I've tested it with the correct file before: Both entries editor-cmd = epm /m and editor-cmd = cmd /c epm /m lead to the same error message, as I've posted above. Or has the syntax changed now, compared to 1.7.21?
Title: Re: Subversion 1.14.0
Post by: Paul Smedley on July 30, 2020, 03:30:54 am
The 'compiled' flag is set by configure - it's not a true compile date/time....
OK. I've tested it with the correct file before: Both entries editor-cmd = epm /m and editor-cmd = cmd /c epm /m lead to the same error message, as I've posted above. Or has the syntax changed now, compared to 1.7.21?

Steven's suggestion is to use '4os2 /c epm /m' as the editor command

I'll try and test this evening - but Lewis/Steven have suggested in email that things are working for them.

Cheers,

Paul.
Title: Re: Subversion 1.14.0
Post by: Andreas Schnellbacher on July 30, 2020, 11:31:35 am
Steven's suggestion is to use '4os2 /c epm /m' as the editor command

I'll try and test this evening - but Lewis/Steven have suggested in email that things are working for them.
I've tried now all combinations: From a VIO shell, "cmd /c" must be prepended to call a PM editor. (It doesn't matter, if 4os2 or cmd is used.) From a PM shell, there exists no variant that works:

Code: [Select]
Test applications:
   VIO shell: cmd.exe, 4os2.exe
   PM shell : epm.exe 'shell', meshell.exe, lcmd.exe (Larsen Commander)

Test command:
   svn ci * (with an altered file in that dir)

editor-cmd      svn.exe 1.14.0 2020-07-28   svn.exe 1.7.21
                VIO shell    PM shell       VIO shell    PM shell   
             
tedit           OK           -              OK           OK
cmd /c tedit    OK           -              OK           OK
epm /m          -            -              OK           OK
cmd /c epm /m   OK           -              OK           OK