31
Networking / Re: Updated Samba Client
« on: January 27, 2024, 10:04:36 pm »
Hi Dave,
The log line:
If I can find a windows exe file, I'll see what the client logs are saying. I have no idea what the NOLARGENTEXEICON setting does and there is definitely no code in Samba that would handle it.
Thanks Paul!
This one does seem to work well - no OOM yet. The last one I never got an OOM either, so you may have squashed that bug. I'll attach logs for the new one. By far the most common line in it is:
2024/01/27 07:50:34.55: 9 2: NdpQueryPathInfo in [0x317ac0] <A.+,;=[].B>
so still see the A.+,;=[].B.
On a different subject - on directories with windows exe files, the WPS blocks while apparently it tries to determine the icons for the files. If the files are large it can take a very long time (minutes - like it reads the whole file) to display and free the WPS. I have 'SET NOLARGENTEXEICON=1' in CONFIG.SYS, but apparently SAMBA doesn't honor that? Have you seen this?
The log line:
Code: [Select]
2024/01/27 07:50:34.55: 9 2: NdpQueryPathInfo in [0x317ac0] <A.+,;=[].B>
Is expected. What has changed in the plugin is the code at https://github.com/psmedley/ndpsmb/blob/samba-4.19.x/src/ndpsmb.c#L1008 where if the WPS is testing A.+,;=[].B, we return immediately rather than calling smbwrp_getattr()If I can find a windows exe file, I'll see what the client logs are saying. I have no idea what the NOLARGENTEXEICON setting does and there is definitely no code in Samba that would handle it.