Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.


Messages - Paul Smedley

Pages: 1 [2] 3 4 ... 140
16
Networking / Re: Updated Samba Client
« on: February 02, 2024, 09:21:56 am »
I rebuilt Samba 4.19.4 to ensure the latest fixes to smbd are also reflected in any other executables that share common libraries.

Latest Server is https://smedley.id.au/tmp/samba-4.19.4-os2-20240202.zip
Latest Netdrive Plugin: https://smedley.id.au/tmp/ndpsmb-20240131.zip
Latest smbcl419.dll: https://smedley.id.au/tmp/smbcl419-4.19.4-20240202.zip

I also updated the 1st post  to include these links to make them easier to find.

17
Paul, here is Uniaud testlog, I hope that is what you are looking for.

Additional information: I tried to switch the devices mit the unimix command and the parameters on, each line said it had success, but in fact it does not switch the devices on. The remain silent.

Ok some quick analysis:
Adapter 0 (which is the default) is routing audit via HDMI  -  which is currently not supported.
Command line mixer for UNIAUD32. Version 1.1
Detected UNIAUD version 3.01.01
Detected 2 audio adapter(s)
Error: invalid number of PCM instances for adapter 1
Card info for adapter 0:
  num: 0
  id: Generic
  driver: HDA-Intel
  name: HD-Audio Generic
  longname: HD-Audio Generic at 0x905c8000 irq 39
  mixer: ATI R6xx HDMI
  componenets: HDA:1002aa01,00aa0100,00100800

It would be interesting to see  'unimix -card' output with  the /a:1 parameter to uniaud32.sys - I know it states 'Error: invalid number of PCM instances for adapter 1' but that may be fixable.

18
Hi Sigurd - did you ever post  a 'testlog uniaud'? Not sure if I missed it or not.

19
Networking / Re: Updated Samba Client
« on: January 31, 2024, 09:22:14 am »
Hey Dave,

Any change with WPS with https://smedley.id.au/tmp/ndpsmb-20240131.zip  ? Chatting with Steven -  it seems NO_ERROR might be a better return code at https://github.com/psmedley/ndpsmb/blob/samba-4.19.x/src/ndpsmb.c#L1011

That's the only change from the last build (not committed yet).

Cheers,

Paul

20
Networking / Re: Samba Users and Groups
« on: January 28, 2024, 07:27:26 am »
Can you try removing ALL  old tdb and lock files before trying to restart things?

21
Networking / Re: Updated Samba Client
« on: January 28, 2024, 01:35:12 am »
@Paul
Quote
I have no idea what the NOLARGENTEXEICON setting does and there is  definitely no code  in Samba that would handle it

From REXX T&T:
Code: [Select]
SET NOLARGENTEXEICON=n
Limit the number of megabytes (=n) the WPS should scan through Windows EXE files for the program icon before assigning a default icon

Available: New kernels from testcase (APAR PJ27886)
Source: XWorkplace Mailinglist

Thanks - I've downloaded https://github.com/open-watcom/open-watcom-1.9/releases/download/ow1.9/open-watcom-c-win32-1.9.exe and will see if I can reproduce this.

Edit: I can reproduce this - however - I don't think the plugin is doing anything wrong. I set SET NOLARGENTEXEICON  on a client - but the NdpFileRead calls are identical. Maybe  it's a bug in Netdrive? I suspect the same issue would be seen with other Netdrive plugins, but I don't have any installed to be able to test.

22
Networking / Re: Updated Samba Client
« on: January 28, 2024, 12:52:21 am »
What has changed in the plugin is the code at https://github.com/psmedley/ndpsmb/blob/samba-4.19.x/src/ndpsmb.c#L1008 where if the WPS is testing A.+,;=[].B,  we return immediately rather than calling smbwrp_getattr()
While this certainly is a performance benefit, I think this approach just 'cures' a symptom but does not address it's root cause. Obviously, smbwrp_getattr() has a memory leak. Just checking for a specific name doesn't prevent the same problem resurfacing in other situations.

I look forward to seeing your fix for the memory leak in smbwrp_getattr(). Afaict the code is basically identical to what's in Samba. I've spent hours staring at the code looking for what might be causing a leak. also note that neither client or server are demonstrating an out of memory condition - the error comes from the *mapping* of a Samba error to Unix style error codes on the *server* which manifests on the client.

23
Networking / Re: Updated Samba Client
« on: January 27, 2024, 10:05:51 pm »
It's like the whole EXE has to be read in order for ANY info to actually show.

Interesting.... a set  of client logs showing this would be interesting - it may be possible to fix  in the plugin.

24
Networking / Re: Updated Samba Client
« on: January 27, 2024, 10:04:36 pm »
Hi Dave,

Thanks Paul!

 This one does seem to work well - no OOM yet. The last one I never got an OOM either, so you may have squashed that bug. I'll attach logs for the new one. By far the most common line in it is:

2024/01/27 07:50:34.55: 9 2: NdpQueryPathInfo in [0x317ac0] <A.+,;=[].B>

so still see the A.+,;=[].B.

 On a different subject - on directories with windows exe files, the WPS blocks while apparently it tries to determine the icons for the files. If the files are large it can take a very long time (minutes - like it reads the whole file) to display and free the WPS. I have 'SET NOLARGENTEXEICON=1' in CONFIG.SYS, but apparently SAMBA doesn't honor that? Have you seen this?

The log line:
Code: [Select]
2024/01/27 07:50:34.55: 9 2: NdpQueryPathInfo in [0x317ac0] <A.+,;=[].B>
Is expected. What has changed in the plugin is the code at https://github.com/psmedley/ndpsmb/blob/samba-4.19.x/src/ndpsmb.c#L1008 where if the WPS is testing A.+,;=[].B,  we return immediately rather than calling smbwrp_getattr()

If I can find a windows exe file, I'll see what the client logs  are saying.  I have no idea what the NOLARGENTEXEICON setting does and there is  definitely no code  in Samba that would handle it.

25
Networking / Re: Updated Samba Client
« on: January 27, 2024, 09:22:27 am »
https://smedley.id.au/tmp/ndpsmb-20240127.zip should be functionally identical to 20240126b but has some cleanups to the code.

26
Networking / Re: Updated Samba Client
« on: January 26, 2024, 09:58:01 pm »
Wow! That is promising. I'll clean up the changes and commit them anyway -  even if they don't 100% fix your issue,  they still reduce unnecessary traffic between the  client and server which is a good thing.

27
Networking / Re: ArcaMapper and Network Protocols
« on: January 26, 2024, 09:56:51 pm »
Given we're now seeing  a connection (which we weren't previously),  and that  Windows can connect without modification, I would remove the following from smb.conf:
Code: [Select]
   client lanman auth = yes
   client min protocol = NT1
   client NTLMv2 auth = no
   client plaintext auth = yes

and try with the defaults. Is that the full log.smbc? It seems shorter than I would expect...

28
Networking / Re: ArcaMapper and Network Protocols
« on: January 26, 2024, 04:14:12 am »
Hey Mark - glad we're making progress -  if you re-enable log level in smb.conf, and recreate ndpsmb.dbg and capture a log - the full log may tell us what the authentication problem is and guide how to fix it.

29
Networking / Re: Updated Samba Client
« on: January 26, 2024, 01:04:28 am »
ok,  https://smedley.id.au/tmp/ndpsmb-20240126b.zip  should get rid of the remaining cases like:
Code: [Select]
2024/01/25 18:28:32.09: 9 2: NdpQueryPathInfo in [0x317ac0] <Great Defrost 2012, LW pics\A.+,;=[].B>
2024/01/25 18:28:32.09: 9 2: dircache_find_path [Great Defrost 2012, LW pics\A.+,;=[].B]
2024/01/25 18:28:32.09: 9 2: dcFindPath: [Great Defrost 2012, LW pics][A.+,;=[].B]
2024/01/25 18:28:32.09: 9 2: dircache: FindPath Great Defrost 2012, LW pics\A.+,;=[].B not found
2024/01/25 18:28:32.09: 9 2: NdpQueryPathInfo pathparser for <\A.+,;=[].B> rc=0
2024/01/25 18:28:32.09: 9 2: NdpQueryPathInfo smbwrp_getattr for <\A.+,;=[].B>

I don't think this is going to fix things, but it makes the code more efficient by not calling smbwrp_getattr() on every folder to check file attributes for A.+,;=[].B which are never going to exist.

30
Networking / Re: Updated Samba Client
« on: January 26, 2024, 12:23:33 am »

Pages: 1 [2] 3 4 ... 140