Messages

1

Programming / Re: Qt6 Application Testing

« on: January 10, 2025, 04:42:05 am »

Hi/2.

Code: [Select]

return fp.isEmpty() || (fp.at(1) != u':' && fp.at(2) != u'/')  || fp.at(0) != u'/';
This is wrong, because 'x:/' is determined as a relative path. Correct is like:

Code: [Select]

return fp.isEmpty() || (fp.at(0) != u'/' && fp.at(1) != u':')
If fp.at(2) != u'/' is used, 'x:dir' style, which is a drive-relative path, is determined as a relative path. BTW, some codes making an absolute path concatenate a relative path to a current path. In this case, 'x:dir' is appended to a current path like '/curdir/x:dir', which is wrong. So a drive-relative path should not be treated as a relative path.

2

Programming / Re: Qt6 Application Testing

« on: January 09, 2025, 10:22:17 am »

Hi/2.

Code: [Select]

bool QFSFileEngine::isRelativePath() const
{
    Q_D(const QFSFileEngine);
    const QString fp = d->fileEntry.filePath();
#ifndef Q_OS_OS2
    return fp.isEmpty() || fp.at(0) != u'/';
#else
    return fp.isEmpty() || (fp.at(1) != u':' && fp.at(1) != u'/');
#endif
}


Code: [Select]

fp.at(1) != u'/'
 should be

Code: [Select]

fp.at(0) != u'/'
right?

3

Programming / Re: Qt6 Development

« on: January 05, 2025, 01:21:51 pm »

I've tested [git worktree] on a SMP machine with 2 CPUs, and it has succeeded without any problems.

Good luck!

4

Programming / Re: Qt6 Development

« on: January 05, 2025, 07:21:10 am »

Nope.

However, [git clone] was done on SMP machine with 2 CPUs. So there will be no problems with [git worktree], too.

Anyway, I'll try this on SMP machine later.

5

Programming / Re: Qt6 Development

« on: January 05, 2025, 07:13:06 am »

I think I have no problems.

F:\lang\work\qt6\qt6-webengine-os2>git worktree add ../qt6-webengine-os2-6.5.x 6
.5.x
Preparing worktree (new branch '6.5.x')
branch '6.5.x' set up to track 'origin/6.5.x'.
Updating files: 100% (216236/216236), done.
HEAD is now at 690d5480cf More OS2_SHORT_NAME fixes for compatability with rpm c
make

F:\lang\work\qt6\qt6-webengine-os2>cd..

F:\lang\work\qt6>cd qt6-webengine-os2-6.5.x

F:\lang\work\qt6\qt6-webengine-os2-6.5.x>git branch
* 6.5.x
+ main

F:\lang\work\qt6\qt6-webengine-os2-6.5.x>

6

Programming / Re: Qt6 Development

« on: January 05, 2025, 05:21:50 am »

How can I do that?

7

Programming / Re: Qt6 Development

« on: January 04, 2025, 10:56:00 am »

Hey there,

Fill your boots if you want to try this. But our git port sucks on large repositories. I'd rather spend time fixing actual issues with qt6 that restructing the git repo. Building each module separately really isn't that difficult.

What's the sucking point of git on large repos ?

As Dave has also mentioned, try cloning https://github.com/psmedley/qt6-webengine-os2.git

The clone will more than likely hang part way through. I've had slightly more success changing acpi.psd to use MAXCPU=1 to get a successful clone.

NB: I haven't tried this with your latest git, just the ones from netlabs and an older port of yours.

I tried to clone it. But git crashed silently when [Updating files] is about 61%. Fortunately, popuplog.os2 said git crashed due to SYS3171.

The stack size of git was 1MB, so I incrased the stack size of git to 8MB with

emxstack -s8192 git.exe

Then, I could clone the repo successfully like:

F:\lang\work\qt6>git clone https://github.com/psmedley/qt6-webengine-os2.git qt6
w.git
Cloning into 'qt6w.git'...
remote: Enumerating objects: 547695, done.
remote: Counting objects: 100% (779/779), done.
remote: Compressing objects: 100% (615/615), done.
remote: Total 547695 (delta 321), reused 301 (delta 157), pack-reused 546916 (fr
om 1)
Receiving objects: 100% (547695/547695), 896.24 MiB | 4.67 MiB/s, done.
Resolving deltas: 100% (314167/314167), done.
Updating files: 100% (212296/212296), done.

And [git status], [git fsck] said the repo was ok.

Any additional tests are necessary ?

8

Programming / Re: Qt6 Development

« on: January 03, 2025, 12:35:11 pm »

Hi/2.

Fill your boots if you want to try this. But our git port sucks on large repositories. I'd rather spend time fixing actual issues with qt6 that restructing the git repo. Building each module separately really isn't that difficult.

What's the sucking point of git on large repos ?

9

Programming / Re: DISKIO - storage device detection logic

« on: December 23, 2024, 04:38:10 am »

Hi/2.

Parameter Packet Format of DSK_GETDEVICEPARMS(63H) of Category 08H has command information member. If it is set to 1, then it tries to read from a media currently in a drive.

DSK_GETDEVICEPARAMS (63h) - Command Information

    Command Information
        A byte with bit 0 defined as follows:

        Return the recommended BPB for the drive, which is the BPB for the physical device, unless it is a formatted fixed media. Then, it is the BPB that was on the media when the system was booted.
        Return the BPB for the media currently in the drive. This always reads the BPB off the current media in the drive. An error is returned if the media is unformatted.

        All other bits are reserved, and must be set to 0.

I think, DosCevIOCtl() will return an error if a media is not connected.

10

Programming / Re: DISKIO - Dhrystone benchmark calc

« on: December 21, 2024, 03:25:49 pm »

Hi/2.

How about changing

   /* now calculate runs per second */
   ulDhryStones = Number_Of_Runs * 100 / lDhryTime;

to

   /* now calculate runs per second */
   ulDhryStones = (long long)Number_Of_Runs * 100 / lDhryTime;

or

   /* now calculate runs per second */
   ulDhryStones = Number_Of_Runs * 100LL / lDhryTime;

?

KO Myung-Hun

11

Networking / Re: Updated Samba Client

« on: August 12, 2024, 02:06:06 pm »

Any reason to omit socket dir part such as lp_ncalrpc_dir() and socket_dir?

And in

Code: [Select]

diff --git a/source3/rpc_client/local_np.c b/source3/rpc_client/local_np.c
index 791ded99a..e8f97f127 100644
--- a/source3/rpc_client/local_np.c
+++ b/source3/rpc_client/local_np.c
@@ -555,8 +555,13 @@ struct tevent_req *local_np_connect_send(
  return tevent_req_post(req, ev);
  }
 
+#ifndef __OS2__
+ state->socketpath = talloc_asprintf(
+ state, "\\socket\\np\\%s", lower_case_pipename);
+#else
  state->socketpath = talloc_asprintf(
  state, "%s/np/%s", socket_dir, lower_case_pipename);
+#endif
  if (tevent_req_nomem(state->socketpath, req)) {
  return tevent_req_post(req, ev);
  }

I think, #ifndef is a typo. It should be #ifdef, right ?

12

Programming / Re: GCC - updates

« on: August 11, 2024, 01:28:40 pm »

I think gcc_assert() is intentional to prohibit to use `%b' and/or `%B' in linker command. The comment is for gcc_assert() line.

In future, it would be better to drop to use `%b' on OS/2, too.

`a.exe' vs `name.exe' is not the show stopper.

Thanks!

13

Networking / Re: Updated Samba Client

« on: August 11, 2024, 01:24:12 pm »

Hi/2.

I suggest to check sun_path which should start with `\socket\'. In case of

  https://github.com/psmedley/samba-os2/blob/samba-os2-4.19.x/source3/lib/util_sock.c#L930

it processes properly.

However,

  https://github.com/psmedley/samba-os2/blob/samba-os2-4.19.x/source3/rpc_client/local_np.c#L558

and

  https://github.com/psmedley/samba-os2/blob/samba-os2-4.19.x/source3/rpc_client/cli_pipe.c#L2976

do not.

These are the result which I've searched with `printf', so I might miss any other parts.

14

Programming / Re: GCC - updates

« on: August 07, 2024, 04:27:15 pm »

Hi/2.

I've fixed and attached the patch.

This is based on 13.3.0. But I think there will be no problem to apply to 14.2.0 tree.

Thanks!

15

Programming / Re: GCC - updates

« on: August 03, 2024, 04:38:39 pm »

This has passed my regression test.

Thanks a lot!