• Welcome to OS2World OLD-STATIC-BACKUP Forum.
 

News:

This is an old OS2World backup forum for reference only. IT IS READ ONLY!!!

If you need help with OS/2 - eComStation visit http://www.os2world.com/forum

Main Menu

CE2mp3

Started by cyber, 2009.06.12, 12:05:45

Previous topic - Next topic

CDRWSel

#135
New build (beta)

0.6.0 - Enabled [advanced] option for audio convertion
       . select part of file to be converted (use of start cut and duration until end of cut)
         Note: enable cut will enable it for all files (setting "start first image" and "duration" + "same all" unchecked disables cut process for the file at run time)    
       . Select a same part time of file to be convert for all files (including files under directories)
         e.g create 10s samples from all files.
       . Overwrite Main(Default) -map setting using one or more -map out of all existing audio stream      
     - Disabled Metadata settings on directories (has no sense)
     - Open WPS directories from directories listed into the conversion list (use enter or click 2 times)
     - Added output stream mapping result into logs
     - Added a flag '*' in front of any ID tags usable for metadata.
     - Disabled DRREXX window to appear in case of unpredictable error.    
     - Corrected some other errors (e.g. corrected stream extracted information from specific stream description)
     note: Help not avalable yet...  

Link:
http // remydodin.levillage. org/ outils/ FFMPEGCA_ S-0_6_0.wpi  (remove any blanks and add the first ':')
To get all required files too, take the full 0.5.0 package first before upgrade.

Cheers/2
Remy

cyber

Grrrr.  :-\

Description: Can't connect to the server.
Server: remydodin.levillage.org:80
Additional info: Error code: 10061

CDRWSel

#137
 :-\  link works again, use following link.
I just updated my following web page to add the latest build:
http://remydodin.levillage.org/ffmpgca.html

Are you interested by main windows resizing ?

abwillis

Haven't had a chance to report... 0.6.1 has worked very well.  The only thing I have noticed is that when the ID3 tags are moved it is hit or miss whether "Track" is brought over.  The same file will one time move it and the next it won't.  Everything else seems to come over, the comment is odd in that for the id3v1 is initially blank on these and a time is added to it which causes different comments to show depending on with what I use to view the tags but seems to be consistent.

CDRWSel

Quote from: abwillis on 2010.06.04, 16:32:26
Haven't had a chance to report... 0.6.1 has worked very well.  The only thing I have noticed is that when the ID3 tags are moved it is hit or miss whether "Track" is brought over.  The same file will one time move it and the next it won't.  Everything else seems to come over, the comment is odd in that for the id3v1 is initially blank on these and a time is added to it which causes different comments to show depending on with what I use to view the tags but seems to be consistent.

Please, send me the logs from a situation + ID3 tags window screenshot.
Then, issue a "ffmpeg -i "your input file" and send me the result.
You can use my email address which is now enabled unde "Contact" on my web link or from the readme file.

cheers/2
Remy


Some news about futur 0.7.0:
- Option to call an external player (usefull to determine cut point) - after some test between Mplayer and KMplayer, preference goes for KMP (tests on video show smooth movie result - needed for futur video development part)
Any suggestion or comment about player to use ?

About video, I did a test creating an OGV file and an html file using HTML5 (ogv) web player.
Result was great.       
     

abwillis

Ok, I've sent the log, screenshots and then a second email where I found that whether "Copy OGG2MP3 tags" is selected seems to determine whether Track or Comments is brought over and that "Use Filename as possible Title" causes the time to be put into the comment field (ID3V1). 
A third email sent had the information from ffmpeg -i as OS2World was down again when I was initially sending so I forgot that piece.  And a 4th email when I realized I had forgotten the logs in the second email when it "Copy OGG2MP3 tags" is unchecked.
The comment field missing is more easily handled for my uses as qoobar will allow me to add it back to everything in a directory at one time and in this case it is essentially always the same.  However, it would be nice if the ID3V2 information could be copied to the ID3V1 fields so that they show up in the WPS.

CDRWSel

Hi Andy!
I didn't get the screenshots not the logs. It looks like somethiong got wrong with attached files. Please, do a try to send them from your mailbox using my email address.
I read other emails and comments. Thank having send them.
A few explananation and may be I have to change how I update ID3 tags.
- If input file has ID3V1 tags, there are copied into ID3V2 too (not removed from ID3V1)
- If input file has only ID3V2 tags and some empty fields exist into "matadatas" or with try to use title... I use these information to update empty fields
- When allways is ok, you may have ID3V1 + ID3V2 tags in output file. May be you have more than one comment fileds into ID3V2 each comment field has an additional flag telling from where it comes. It could be from ID3V1 copied inot ID3V2 or from FFMPEGCA added entry. Issue ID3V2 -l "your converted file" and check COMM entries... How many COMM entries do you have and can you please put them here. Thanks

It seems a error could occur in some cases. I'll review my code and add an option to disable adding ID3V1 if these should not be written...

Thanks for feedback which is always very important to have the best program result.
Cheers
Remy     

CDRWSel

#142
I worked more on FFMPEGCA and review ID3 tags process. Try now this new build with following additon and corrections:

0.6.9
- Added Kmplayer and/or Mplayer support to play files (KMP prefered)
 * Once it is configured, click 2 times (enter) on the selected file from the into the list *

- Added option to disable ID3V1 writing tags
- Added Main window min/max button
- Added external option to fully disable adding track time into COMM tag if comment doesn't exist (FFMPEGCA --dct  or --ect to enable again)  
- Corrected possible bug setting ID3 Comment field
- Corrected possible title set to use ID3V1 is ID3V2 seems not to strange!
- modified read of MP3 IDTAGS routine
- Enabled [View] - [Video]
- Futur Video function displaied but not enabled yet (see futur profiles + functions under [advanced]
  note: changing first frame or last frame time using hh:mm:ss needs to lost focus to have the corresponding picture displaied (info message available)  
- Corrected an error handling (found on mp3 input file) adding a RC2 with writting id tags enabled (message added into logs)
- other minor error and text corrected...

File is available on my web page: http://remydodin.levillage.org/ffmpgca.html

Cheers/2
Remy

abwillis

The --dct has indeed stopped the time from being added to the comment section.  But I can't tell any other changes with regard to ID3 tags.  I've tried both "Add both mp3 ID3V1 and ID3V2" both checked and unchecked and don't see any difference.  But I have partly determined what is happening.
When "Copy OGG3MP3 tags" is checked then ID3 tags are copied over, when it is not then only metadata is moved over.  This is why the comment field is not moved over. For ID3V2 the Comment field is not metadata (but is for ID3V1 - very odd decision making they did there).  Track is metadata so it is moved over. 
Now, for some reason, when "Copy OGG2MP3 tags" is checked and the ID3 info is moved over it to my best guess is then wiping the metadata out (can't determine how).  If I use ID3V2 to try to copy the Track info into the MP3 then it gives a libc panic and doesn't do anything but still a return code 0 is given which would account for:
--TRCK " 01" (RC:0) "note: id3v2 may fails with rc99 for this option"
I see now what is happening.  Once id3v2 runs successfully (such as for the comment field) it apparently wipes the metadata.  Because all the metadata is being added back in via the tags this is really not a problem, except that because track causes a libc-panic it is lost when "Copy OGG2MP3 tags" is selected. 
I had not expected ID3V2 to wipe the existing metadata so had thought because the metadata was being added with ffmpeg that Track should have been there despite the problem with id3v2.exe. 
I have been trying to build a newer id3v2 but haven't been successful yet but maybe that will help.  I know there was a bug opened for the issue on Smedley's bug tracker too. 
At this point it looks like your code is fine, it is the toolchain that hopefully will be correctable.
Thanks,
Andy

CDRWSel

#144
Hi Andy,

What I do:

1/ I read metadata using ffmpeg and preset corresponding ID3 tags (because ID3V2 doesn't read metadata).
You have metadata in many kinds of file type. If a COMM metadata is found, it is taken. With --ect, I set COMM to the track duration if this one doesn't exist  
2/ When ogg2mp3 is set (only for OGG), I read OGG tags using ogg tools and correct initial tag settings if needed. Of course, like other parameters, if the COMM field exist, I change it
3/ If the file is a MP3, I read then the corresponding ID3 tags (v1 and v2 if they exist) and overwrite previos set tags with the corresponding tags.
At conversion time, I copy metadatas with the ffmpeg command and as final step, I set mp3 tags using mp3info (for V1 tags) and ID3V2 for V2 tags (with both ID3v1 +° ID3v2 set, I convert written ID3v1 to ID3v2 first before writing ID3v2 - This will add a special comment entry with a [XXX] which indicates it is comming from ID3v1 migration
 
According your selection:
If Adding both IDtag isn't set, ID3 v1 tags are all disabled/removed but some V1 found information corresponding to equal ID3 v2 parameter could be taken if the corresponding ID3 v2 is blank into the source file.

There is no raison to miss some information. At least, result should be exhaustive with found information.
ID3V2 supports more than one COMM entry and if more than one COMM (comment exist, there are all added into the final MP3 file. Run ffmpeg -i "your outfile" and read each entry and then, run ID3V2 -l "your outfile" (-L in lower case) and see how many comments entry exist. I often have 2 different comments entries and each one has an identifier about it's source (with ID3v1 + ID3v2 set, You may have 2 entries and one of them has [xxx] and the second is the one added by ID3V2). Is you tool able to read all ID3V2 comments entries or only one of them ?

ID2V2 goes into panic when you set the --track which always returns rc99 and sometimes rc0! This is why I added a comment into my logs but only this tag goes into error (one write per tag). I left the paramater which has no impact on my system in case ID3V2 will be corrected into a next build!. With V1 tags enabled, TRACK is correctly set. This is why I use this utility too.
If this error is the source of lost of metadatas ! I can make FFMPEGCA disable this option for the current ID3V2 build only. Would it be helpfull ?  

Now,after this long explanation, If something is wrong in the way I add/update MP3 ID tags, please tell it me and I try to correct it.
To resume: (ffmpeg metadata -> existing V1 overwrites same ffmpeg metadata and creates V2 entries -> V2 overwrites same ffmpeg metadata and V2 entries created by V1 step. At ID write time: ffmpeg write metatada - (Write V1 + migrate V1 to V2 if enabled) + write V2 tags whish overwrites existing ID3v2)  

note: I'll check if the delete ID3 V1 tags from ID3V2 is deleting ID3 v1 only or metadatas too !
       (when no ID3 v1 have to be written, I do a delete V1)

Could you test the edit ID tags option ?
* To update ID tags, add the mp3 file to have its ID tags changeds into the list. Select it and click on edit tags.
* Change fields as desired and validate.

The "prepare" option is usable on any files into the list allow you to review existing metadatas, change them and then, these metadatas set as "prepared" for the selected file and are then written into the converted file instead of original metadatas (operation can be done on all files into the list before the conversion. Prepared Metadatas are indexed to correspond to file into the list) 

Cheers/2
Remy

CDRWSel

Ok, using ID3V2 --delete-v1 or --delete-v2 deletes all metadatas too !

I updated FFMPEGCA to 0.7.0 as follow:
  0.7.0 - Added external parameter to fully disable "unwanted id3 tags"
        > FFMPEGCA --ed3 (Enable Delete ID3 tags) or --dd3 (Disable Delete ID3 tags)

Default is as before that is : "delete unwanted ID3 tags"
You can issue --dd3 one time which will always disable this option and no more delete written metadatas at ffmpeg process time.

Cheers/2
Remy   

abwillis

I have built a new id3v2 which allows me to change track (haven't done anymore testing than that so far).
I have sent it via email.

CDRWSel

I did more test since last build and saw some strange issue with ID3V2 and ffmpeg.
When copying input file metadata to ouptput files, metadatas looks like ID3V2 tags but aren't
one entry which is comment isn't converted into COMM.
Now, ID3V2 erases some entries ex: TSSE which is strange
I changed some part of my code to well take the TSSE and have the input comment field well tranlates into COMM after ffmpeg convesion....
I'll have a look on you id3v2 build and comme back soon...

Cheers/2
Remy       
     

abwillis

From the logs:
--TRCK " 01"
can the space be removed? as:
--TRCK "01"
With my id3v2 the space does stop pm123 and id3v2  from seeing the track number as is but qoobar does not.  Removing the space allows it to be seen by pm123, id3v2 and qoobar. 

CDRWSel

Hi Andy,

Well done with your ID3V2 build   ;)
I reworked part of the code to use this build nad I could remove some routine I added to bypass some options which didn't well work into older ID3V2.

I emailed you the link to my web server to get the 0.7.1 build for deeper test before I put it online for every body.
Read all changes I made in it and new adds. As soon you think it is ok, I'll put it available with your id3v2 as requirement for best results.     
The extra blank should be ok too.

Thanks
Cheers/2
Remy