• Welcome to OS2World OLD-STATIC-BACKUP Forum.
 

News:

This is an old OS2World backup forum for reference only. IT IS READ ONLY!!!

If you need help with OS/2 - eComStation visit http://www.os2world.com/forum

Main Menu

CE2mp3

Started by cyber, 2009.06.12, 12:05:45

Previous topic - Next topic

cyber

Huh...
I'v got
Sytax error
SAY "Ddosrc =" Ddosrc
Ddosrc = rxcreatenpipe('hpipe' /pipename,openomde,pipemode,instance_count,

can not see all.

Is it may dependent on some more dll's, not only rxu.dll ???

Anyone else ???

CDRWSel

#76
...Hum strange !
May be only some functions from the dll were loaded and not those needed by the cdrwbar (this could happen with some programs only loading required functions and not dropping them at close time).
I added a dll check into this build. If required function aren't loaded, then I do a drop of the dll followed by a full load. I added a message in case the dll couldn't be loaded.
Hope this help.
Bye/2
Remy

ps: of course, general RexxUtil.dll is required too

cyber

#77
RD4 is not working on both my computers, except that on eCSv2b4 do conversion without progres indicator move, and on W4 result with error without making conversion.
It aplyes for both CHK_Duration=1 and CHK_Duration=0

Question:
Is there more than one version of RexxUtil.dll and / or rxu.dll ?

cyber

Quote from: Batchheizer on 2009.07.14, 11:13:38
Quote from: cyber on 2009.07.14, 09:38:01
And if tagv2 exist and tagv1 does not, it will be just tagv2->tagv2 !
Is this OK ?
In the last case copy tagv2 to tagv1. Maybe they are cutted - but this is better than none ID3V1- because many OS2-porgrams can only read ID3V1 (minta; CW_Classes etc.).

There is to many combinations for v2->v1...module for tag reading, combinyng and writing is almost big as ce2mp3 without it  :)... for example title1 and title2 in v2 tag are set, and title in v1 tag is empty, but both titles from v2 are ahem... important... wich one to set as v1 tag.  Not to speak about comments.  ???  Anyway... mp3 module is in test phase.

CDRWSel

#79
Quote from: cyber on 2009.07.20, 16:49:55
RD4 is not working on both my computers, except that on eCSv2b4 do conversion without progres indicator move, and on W4 result with error without making conversion.
It aplyes for both CHK_Duration=1 and CHK_Duration=0

Question:
Is there more than one version of RexxUtil.dll and / or rxu.dll ?

Hi Cyber,
I don't understand what happens under your system !  did you run special programs or tools replacing original dll by different version ?. I just did a few test under 2 more different machine and ecs level and it was well too !
Stop all of your special tools and programs using pause in it because as I wrote, it has unpredictable result on pipe process.
If you didn't get a message about dll not loaded, then it was loaded but it could not proceed as expected due to other program disturbing the open pipe !! but, first, review all your dll path and remove all duplicate dll and unwanted dll's to prevent wrong dll loading.
rxu.dll :
2/05/96 22:11        199 012    221 a---  rxu.dll
rexxutil.dll :
6/09/00 12:42         68 119      0 a---  REXXUTIL.DLL

note: it is compatible with os/2 warp connect (W3), W4, W4.5 and eCS ....
Question : did you load special (open) object rexx dll's or modified/updated rexxutil version ? If yes, unload them.

cyber

Bug (feature?) found:

Call SysFileTree ARG(1)||v1ideost"\*", "files", "FO"
do i = 1 to files.0

does not work if v1ideost is directory contain spaces.

Call SysFileTree ARG(1)||"'"v1ideost"\*'", "files", "FO"
Call SysFileTree ARG(1)||'"'v1ideost'\*"', "files", "FO"

does not work too ?
suggestions ?

CDRWSel

#81
Hi !
Did you see the screenshot I put into the last build, directory and files have blank characters in it and it works well here !
Can you provide a list of all dll's you have under os2/dll and ecs/dll
Check your config.sys dll path that these two paths are at first places in you paths list. If not, correct it and reboot.
Remy

note: when you will add "   ", you'll have to quote full path and not only the directory or filename.
e.g.   "c:\mymusic\classic concert\.*"   (this is ok while c:\mymusic\"classic concert"\.* isn't
other example:  '"'ARG(1)||v1ideost'\*"' 


   

cyber

Hmmm... there is more different ways of how You can execute something under OS/2 / eCS.

Problem in my case was using File Comander as shell; when You pass directory with path, using [ctrl] [f], FC pass argument if have spaces under quotes; for example ctrl F on c:\dir\d i r will result with 'ce2mp3 "c:\dir\d i r"'.  With quotes (") stream wont work here, and at the first not even trigger jump to procdir:  trying to treat "c:\dir\d i r" like file. Strip quotes from argument to stream can handle this and back 'em later before start ffmpeg cure problem. It just coincidence that I wasn't try dir with spaces till now.

   This is not case if You using GUI PMshell, or type manualy without quotes in command line. And this 'cure' do not affect those ways.

change at start where stream(v1ideost, C, 'query size')
------>8------>8------>8------>8------>8------>8
filebytes = 0
tagstr=d2C(34)           /* strip " from v1ideost */
v1ideost  = strip( v1ideost , l, tagstr) 
v1ideost  = strip( v1ideost , t, tagstr) 
filebytes = stream(v1ideost, C, 'query size') /* determine is it file or dir */
IF filebytes = 0 then call ProcDir  /* if dir jump to ProcDir else continue */
IF filebytes = "" then call ProcDir  /* some special cases not sure need anymore */
------>8------>8------>8------>8------>8

and add line to return quotes
------>8------>8------>8------>8------>8
v1ideost='"'v1ideost'"'
------>8------>8------>8------>8------>8
just before showing info about source file with
FFmpeg_pth" -i "v1ideost

--------------------------------------------------------
Looks like this changes handle all cases and works OK.

It is now become a usable tool, to prepare bunch of files for old mp3 player. :)

cyber

Quote from: CDRWSel on 2009.07.21, 23:03:16
I don't understand what happens under your system !  did you run special programs or tools replacing original dll by different version ?. I just did a few test under 2 more different machine and ecs level and it was well too !

I'm think not. This eCS v2 b4 is mostly 'fresh' install under Virtual PC at my office, and except installed OOo and PMview  almost used only for writing ce2mp3.  What I really not understand is why no one else can confirm working or not status. I'm not the only downloaded Your releases.

Quote from: CDRWSel on 2009.07.21, 23:03:16
Stop all of your special tools and programs using pause in it because as I wrote, it has unpredictable result on pipe process.
If you didn't get a message about dll not loaded, then it was loaded but it could not proceed as expected due to other program disturbing the open pipe !! but, first, review all your dll path and remove all duplicate dll and unwanted dll's to prevent wrong dll loading.
rxu.dll :
2/05/96 22:11        199 012    221 a---  rxu.dll
rexxutil.dll :
6/09/00 12:42         68 119      0 a---  REXXUTIL.DLL

note: it is compatible with os/2 warp connect (W3), W4, W4.5 and eCS ....
Question : did you load special (open) object rexx dll's or modified/updated rexxutil version ? If yes, unload them.

DLL's same on this machine, nothing modified/updated. Fresh boot and first thing is starting Your program. Nothing is different. Cemp3 and cdrwbar work normaly for both file/dir cases, it is only progress bar not travel from left to right.
If other (Batchheizer ?) happy with this version, I'm not care about progress bar, I'm building text version for me. :)

cyber

#84
Who need port of Quake III to OS/2 when we can program in Rexx !  ;D

CE2MP3v8.zip - mp3 tag transfer to result files.   8)
4RDce2mp3tag.zip - tag module upgrade for CDRWSel

CDRWSel

Progress bar not "travelling" means that messages aren't incoming from pipe !   
I have vpc and will do one more test under a fresh installed eCs.
bye/2
Remy     

CDRWSel

Hi Cyber !
I could reproduce the problem you have but only under ecs in VPC (I only did the tests on ecs host systems - this was the missing info "VPC")
* first comment: messages are well received from open pipe
I will investigate why the progress bar isn't scrolling in this situation and tell you soon ....
Bye/   
Remy

CDRWSel

#87
Hi Cyber,
Good news, I found the raison of this bug and I corrected it.
The raison:
under native OS/2 or eCS, the pipe returns the message into one line:
  Duration: 00:01:12.84, start: 0.000000, bitrate: 59 kb/s
but under VPC, only this usefull 'duration' message line is splitted into many lines !
  Duration:
  00:01:12.84,
  start:
  0.000000,
  ...
I was searching for the string "duration" and I took the time from the same line but under VPC, the time after duration is not set and the initial 0 default value is used due to missing information on the same line !
I added a code to add next line to current line if 'duration' is found after pos 2 (this si ok in any cases)
I changed the message in case of pipe could not be opened to a rxmessagebox with 'cancel' which closes cdrwbar now to prevent:
" Syntax error
  SAY "Ddosrc =" Ddosrc
  Ddosrc = rxcreatenpipe('hpipe' /pipename,openomde,pipemode,instance_count,"

Due to this strange result, I will now test my rexx under VPC too  ;)

Here is cdrwbar build to test.

PS: I'll review your latest update and put updated ce2mp3 with cdrwbar support online soon     

CDRWSel

#88
Hi !
I updated ce2mp3 usable with cdrwbar
* you can disable cdrwbar if needed (change internal option)
* added latest cyber changes (with correction processing directories)
* added time stamp tag
* added option to use filename as title if no titletag exist
* added log files
* changed id3v2 writing tag to one run
* reviewed single track or directory routine to use same quoted rules
* Added support to convert mp3 files in the same path as destination path (new track is prefixed by "(new)"

** install rxu.dll from rxu1a.zip under .\ecs\dll or .\os2\dll **
** use ogginfo and id3v2 from previous pages **
** use previous cdrwbar_1.4.9.zip with this update **
** Enjoy and give feedback   ;)  **                       

CDRWSel

#89
Hi Cyber, I updated ce2mp3 (usable with cdrwbar)

* corrected a wrong id3v1 date tag extraction on mp3 files
* added a very simple codepage converter to translate some specific french characters + " ' " (experimental) due to default id3 codepage versus OS/2 codepage (850 or other)
* ID3 write tag is no more called if ffmpeg fails.
* Corrected ID3 tag to respect mixed characters according original id3 tags ( changed pull xxx to parse pull xxx )
* Corrected ID3 tags from ogg tracks

Default title option (can be disabled) is to take track name if no Title tag exist
If no OGG comment tag exist, the playback time is added into this field.

cdrwbar: added support up to 32 ffmpeg returned "error" messages (not code problem..) before progress bar *aborts* (was one error = stop before)   
Progress bar is dark red after first received error message.
(e.g. of error : "out of space on disk" but it isn't wrote like this in ffmpeg!)